From: ben.dooks@codethink•co.uk (Ben Dooks)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: i.MX6: update KSZ9031 phy fixup
Date: Wed, 02 Apr 2014 15:14:43 +0100 [thread overview]
Message-ID: <533C1B53.8070506@codethink.co.uk> (raw)
In-Reply-To: <20140402153855.237e7a50@e6520eb>
On 02/04/14 14:38, Eric B?nard wrote:
> Hi Shawn,
>
> Le Wed, 2 Apr 2014 21:14:08 +0800,
> Shawn Guo <shawn.guo@linaro•org> a ?crit :
>
>>
>> On Mon, Mar 24, 2014 at 04:41:41PM +0100, Eric B?nard wrote:
>>> Hi Hubert,
>>>
>>> Le Mon, 24 Mar 2014 16:30:49 +0100 (CET),
>>> CHAUMETTE Hubert <hchaumette@adeneo-embedded•com> a ?crit :
>>>>> From: "Eric B?nard" <eric@eukrea•com>
>>>>> that's board specific (the needed delay depends on the routing delay on
>>>>> the PCB), so this should not go in a generic file.
>>>>>
>>>>> Eric
>>>>>
>>>>
>>>> I admit it may need to be in a separate function, but this file already contains
>>>> board-specific fixups (for imx6q sabrelite, Data Modul eDM-QMX6).
>>>>
>>> true but that's not a reason to add more ;-)
>>>
>>>> Anyway, do you have any suggestion for the location I should put it ?
>>>>
>>> no idea at the moment, I simply used your patch to bring this issue on
>>> the ML as we recently needed to patch the default values for testing
>>> mainline kernel on a custom boards.
>>
>> Hmm, can such board-specific fixups be pushed down to bootloader?
>>
> that won't work if the kernel reset the PHY.
If it is in device-tree, then you can add it to the phy node.
For earlier Micrel Phys we have a LED mode setting on initialisaion.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
next prev parent reply other threads:[~2014-04-02 14:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 17:08 [PATCH] ARM: i.MX6: update KSZ9031 phy fixup Hubert Chaumette
2014-03-21 21:23 ` Eric Bénard
2014-03-24 15:30 ` CHAUMETTE Hubert
2014-03-24 15:41 ` Eric Bénard
2014-04-02 13:14 ` Shawn Guo
2014-04-02 13:38 ` Eric Bénard
2014-04-02 14:14 ` Ben Dooks [this message]
2014-04-02 20:01 ` Anatolij Gustschin
2014-04-03 14:05 ` Hubert Chaumette
2014-04-03 14:56 ` Anatolij Gustschin
2014-04-06 11:06 ` Shawn Guo
2014-04-06 11:26 ` Russell King - ARM Linux
2014-04-06 12:04 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533C1B53.8070506@codethink.co.uk \
--to=ben.dooks@codethink$(echo .)co.uk \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox