From: syin@broadcom•com (Sherman Yin)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] pinctrl: capri: make Kconfig dependency more strict
Date: Wed, 2 Apr 2014 16:19:58 -0700 [thread overview]
Message-ID: <533C9B1E.6020905@broadcom.com> (raw)
In-Reply-To: <1396383021-2295-1-git-send-email-u.kleine-koenig@pengutronix.de>
On 14-04-01 01:10 PM, Uwe Kleine-K?nig wrote:
> This driver is only useful on BCM281xx, so let the driver depend on
> ARCH_BCM_MOBILE but allow compile coverage testing.
> The main benefit is that the driver isn't available to be selected for
> machines that don't have the matching hardware.
>
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix•de>
> ---
> drivers/pinctrl/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index e49324032611..072749816cb4 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -106,7 +106,7 @@ config PINCTRL_BCM2835
>
> config PINCTRL_CAPRI
> bool "Broadcom Capri pinctrl driver"
> - depends on OF
> + depends on OF && (ARCH_BCM_MOBILE || COMPILE_TEST)
> select PINMUX
> select PINCONF
> select GENERIC_PINCONF
>
Looks good. Just wondering how you've come across this driver (and
PINCTRL_MSM8X74)?
Reviewed-by: Sherman Yin <syin@broadcom•com>
Thanks,
Sherman
next prev parent reply other threads:[~2014-04-02 23:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-01 20:10 [PATCH] pinctrl: capri: make Kconfig dependency more strict Uwe Kleine-König
2014-04-02 23:19 ` Sherman Yin [this message]
2014-04-03 8:01 ` Uwe Kleine-König
2014-04-10 16:55 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533C9B1E.6020905@broadcom.com \
--to=syin@broadcom$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox