From: ivan.khoronzhuk@ti•com (Ivan Khoronzhuk)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand
Date: Tue, 8 Apr 2014 15:51:34 +0300 [thread overview]
Message-ID: <5343F0D6.2010804@ti.com> (raw)
In-Reply-To: <532B4C36.8060405@ti.com>
On 03/20/2014 10:14 PM, Santosh Shilimkar wrote:
> On Thursday 20 March 2014 04:08 PM, Ivan Khoronzhuk wrote:
>> From: Murali Karicheri <m-karicheri2@ti•com>
>>
>> Sub page write doesn't work because of hw issue in controller found on
>> Keystone SOCs. AEMIF controller is also used on DaVinci SOCs which
>> don't seems to have any issue. So add "ti,keysone-nand" compatible
>> to nand driver in order to set NAND_NO_SUBPAGE_WRITE option.
>>
>> Cc: Brian Norris <computersforpeace@gmail•com>
>> Cc: Warner Losh <imp@bsdimp•com>
>> Cc: Santosh Shilimkar <santosh.shilimkar@ti•com>
>>
>> Signed-off-by: Murali Karicheri <m-karicheri2@ti•com>
>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti•com>
>> ---
>>
> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti•com>
>
>> This patch is a result of discussion on patch v1:
>> https://lkml.org/lkml/2014/3/20/461
>>
>> drivers/mtd/nand/davinci_nand.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
>> index 4615d79..b922c8e 100644
>> --- a/drivers/mtd/nand/davinci_nand.c
>> +++ b/drivers/mtd/nand/davinci_nand.c
>> @@ -523,6 +523,7 @@ static struct nand_ecclayout hwecc4_2048 = {
>> #if defined(CONFIG_OF)
>> static const struct of_device_id davinci_nand_of_match[] = {
>> {.compatible = "ti,davinci-nand", },
>> + {.compatible = "ti,keystone-nand", },
>> {},
>> };
>> MODULE_DEVICE_TABLE(of, davinci_nand_of_match);
>> @@ -581,6 +582,11 @@ static struct davinci_nand_pdata
>> of_property_read_bool(pdev->dev.of_node,
>> "ti,davinci-nand-use-bbt"))
>> pdata->bbt_options = NAND_BBT_USE_FLASH;
>> +
>> + if (of_device_is_compatible(pdev->dev.of_node,
>> + "ti,keystone-nand")) {
>> + pdata->options |= NAND_NO_SUBPAGE_WRITE;
>> + }
>> }
>>
>> return dev_get_platdata(&pdev->dev);
>>
>>
Brian,
Could you pick up subj patch?
--
Regards,
Ivan Khoronzhuk
next prev parent reply other threads:[~2014-04-08 12:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 20:08 [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand Ivan Khoronzhuk
2014-03-20 20:14 ` Santosh Shilimkar
2014-04-08 12:51 ` Ivan Khoronzhuk [this message]
2014-04-16 7:08 ` Brian Norris
2014-04-16 9:47 ` Ivan Khoronzhuk
2014-04-16 14:03 ` Santosh Shilimkar
2014-04-28 13:43 ` Santosh Shilimkar
2014-04-30 22:33 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5343F0D6.2010804@ti.com \
--to=ivan.khoronzhuk@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox