From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC 3/5] PCI: tegra: Implement accurate power supply scheme
Date: Tue, 08 Apr 2014 13:20:57 -0600 [thread overview]
Message-ID: <53444C19.2080904@wwwdotorg.org> (raw)
In-Reply-To: <1396622969-17837-4-git-send-email-treding@nvidia.com>
On 04/04/2014 08:49 AM, Thierry Reding wrote:
> The current description of power supplies doesn't match the hardware.
> Instead it's designed to support the needs of current designs, which
> will break as soon as a new design appears that cannot be described
> using the current assumptions.
>
> In order to fully support all possible future designs, all power supply
> inputs to the PCIe block need to be accurately described and separately
> configurable.
> diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c
> @@ -930,23 +927,9 @@ static void tegra_pcie_power_off(struct tegra_pcie *pcie)
> - err = regulator_disable(pcie->pex_clk_supply);
> + err = regulator_bulk_disable(pcie->num_supplies, pcie->supplies);
> if (err < 0)
> - dev_warn(pcie->dev, "failed to disable pex-clk regulator: %d\n",
> - err);
> -
> - err = regulator_disable(pcie->vdd_supply);
> - if (err < 0)
> - dev_warn(pcie->dev, "failed to disable VDD regulator: %d\n",
> - err);
> + dev_warn(pcie->dev, "failed to enable regulators: %d\n", err);
s/enable/disable/
next prev parent reply other threads:[~2014-04-08 19:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 14:49 [RFC 0/5] PCI: tegra: Overhaul regulator usage Thierry Reding
2014-04-04 14:49 ` [RFC 1/5] " Thierry Reding
2014-04-08 19:15 ` Stephen Warren
2014-04-08 19:52 ` Thierry Reding
2014-04-04 14:49 ` [RFC 2/5] ARM: tegra: Add new PCIe regulator properties Thierry Reding
2014-04-08 19:17 ` Stephen Warren
2014-04-08 19:54 ` Thierry Reding
2014-04-04 14:49 ` [RFC 3/5] PCI: tegra: Implement accurate power supply scheme Thierry Reding
2014-04-08 19:20 ` Stephen Warren [this message]
2014-04-08 19:55 ` Thierry Reding
2014-04-04 14:49 ` [RFC 4/5] PCI: tegra: Remove deprecated power supply properties Thierry Reding
2014-04-04 14:49 ` [RFC 5/5] ARM: tegra: Remove legacy PCIe " Thierry Reding
2014-04-08 19:21 ` [RFC 0/5] PCI: tegra: Overhaul regulator usage Stephen Warren
2014-04-25 16:57 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53444C19.2080904@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox