From: svarbanov@mm-sol•com (Stanimir Vabanov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2] ARM: qcom: Add initial APQ8064 SoC and IFC6410 board device trees
Date: Wed, 09 Apr 2014 01:02:24 +0300 [thread overview]
Message-ID: <534471F0.5050800@mm-sol.com> (raw)
In-Reply-To: <1396972391-11759-1-git-send-email-galak@codeaurora.org>
Hi Kumar,
<snip>
> + intc: interrupt-controller at 2000000 {
> + compatible = "qcom,msm-qgic2";
> + interrupt-controller;
> + #interrupt-cells = <3>;
> + reg = < 0x02000000 0x1000 >,
> + < 0x02002000 0x1000 >;
extra space around numbers.
I wonder what is the preferred way of describing the properties:
reg = <0x02000000 0x1000>,
<0x02002000 0x1000>;
or
reg = <0x02000000 0x1000>, <0x02002000 0x1000>;
This file mixes the above two ways of describing.
> + };
> +
> + timer at 200a000 {
> + compatible = "qcom,kpss-timer", "qcom,msm-timer";
> + interrupts = <1 1 0x301>,
> + <1 2 0x301>,
> + <1 3 0x301>;
> + reg = <0x0200a000 0x100>;
> + clock-frequency = <27000000>,
> + <32768>;
> + cpu-offset = <0x80000>;
> + };
> +
> + acc0: clock-controller at 2088000 {
> + compatible = "qcom,kpss-acc-v1";
> + reg = <0x02088000 0x1000>, <0x02008000 0x1000>;
> + };
> +
regards,
Stan
next prev parent reply other threads:[~2014-04-08 22:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 15:53 [PATCH v2] ARM: qcom: Add initial APQ8064 SoC and IFC6410 board device trees Kumar Gala
2014-04-08 22:02 ` Stanimir Vabanov [this message]
2014-04-08 23:26 ` Stephen Boyd
2014-04-08 23:32 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534471F0.5050800@mm-sol.com \
--to=svarbanov@mm-sol$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox