public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: s.nawrocki@samsung•com (Sylwester Nawrocki)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] phy: exynos5-usbdrd: Add facility to toggle vbus gpio on/off
Date: Wed, 09 Apr 2014 14:11:34 +0200	[thread overview]
Message-ID: <534538F6.2010009@samsung.com> (raw)
In-Reply-To: <1397044485-26483-1-git-send-email-gautam.vivek@samsung.com>

Hi Vivek,

On 09/04/14 13:54, Vivek Gautam wrote:
> Adding support to enable/disable VBUS hooked to a gpio
> to enable vbus supply on the port.

Does the GPIO control a fixed voltage regulator ? If so, shouldn't
it be modelled by the regulator API instead ?

> Signed-off-by: Vivek Gautam <gautam.vivek@samsung•com>
[...]
> +	/* Get required GPIO for vbus */
> +	phy_drd->gpio = of_get_named_gpio(dev->of_node,
> +					  "samsung,vbus-gpio", 0);
> +	if (!gpio_is_valid(phy_drd->gpio))
> +		dev_dbg(dev, "no usbdrd-phy vbus gpio defined\n");
> +
> +	if (devm_gpio_request(dev, phy_drd->gpio, "phydrd_vbus_gpio"))
> +		dev_dbg(dev, "can't request usbdrd-phy vbus gpio %d\n",
> +			phy_drd->gpio);

--
Regards,
Sylwester

  reply	other threads:[~2014-04-09 12:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-09 11:54 [PATCH] phy: exynos5-usbdrd: Add facility to toggle vbus gpio on/off Vivek Gautam
2014-04-09 12:11 ` Sylwester Nawrocki [this message]
2014-04-09 12:24   ` Vivek Gautam
2014-04-09 12:38     ` Tomasz Figa
2014-04-10 11:07       ` Vivek Gautam
2014-04-09 13:08     ` Sylwester Nawrocki
2014-04-10  9:09 ` Kishon Vijay Abraham I
2014-04-10 10:32   ` Vivek Gautam
2014-04-12  3:37 ` Felipe Balbi
2014-04-14  8:05   ` Vivek Gautam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=534538F6.2010009@samsung.com \
    --to=s.nawrocki@samsung$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox