From: t.figa@samsung•com (Tomasz Figa)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V3 12/17] ARM: exynos: cpuidle: Move S5P_CHECK_AFTR in a header
Date: Wed, 09 Apr 2014 14:21:34 +0200 [thread overview]
Message-ID: <53453B4E.8000203@samsung.com> (raw)
In-Reply-To: <1396959579-18268-13-git-send-email-daniel.lezcano@linaro.org>
Hi Daniel,
On 08.04.2014 14:19, Daniel Lezcano wrote:
> Move the S5P_CHECK_AFTR definition to the header it belongs to.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro•org>
> Reviewed-by: Viresh Kumar <viresh.kumar@linaro•org>
> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung•com>
> ---
> arch/arm/mach-exynos/cpuidle.c | 2 --
> arch/arm/mach-exynos/regs-pmu.h | 1 +
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach-exynos/cpuidle.c
> index 81d7197..cd27dbf 100644
> --- a/arch/arm/mach-exynos/cpuidle.c
> +++ b/arch/arm/mach-exynos/cpuidle.c
> @@ -37,8 +37,6 @@
> S5P_INFORM6 : (samsung_rev() == EXYNOS4210_REV_1_0 ? \
> (S5P_VA_SYSRAM + 0x20) : S5P_INFORM1))
>
> -#define S5P_CHECK_AFTR 0xFCBA0D10
> -
> #define EXYNOS5_PWR_CTRL1 (S5P_VA_CMU + 0x01020)
> #define EXYNOS5_PWR_CTRL2 (S5P_VA_CMU + 0x01024)
>
> diff --git a/arch/arm/mach-exynos/regs-pmu.h b/arch/arm/mach-exynos/regs-pmu.h
> index 4f6a256..09c43c3 100644
> --- a/arch/arm/mach-exynos/regs-pmu.h
> +++ b/arch/arm/mach-exynos/regs-pmu.h
> @@ -120,6 +120,7 @@
> #define S5P_INT_LOCAL_PWR_EN 0x7
>
> #define S5P_CHECK_SLEEP 0x00000BAD
> +#define S5P_CHECK_AFTR 0xFCBA0D10
This is not really a PMU-specific value. It is not a part of the
hardware programming interface, but rather a part of the
kernel-bootloader ABI used to handle wake-up from low power states. Same
applies to S5P_CHECK_SLEEP.
I believe the proper place for such definitions would be the source file
using it, which after patch 14/17 would be pm.c.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-04-09 12:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 12:19 [PATCH V3 00/17] ARM: exynos: cpuidle: Move the driver to drivers/cpuidle Daniel Lezcano
2014-04-08 12:19 ` [PATCH V3 01/17] ARM: exynos: cpuidle: Prevent forward declaration Daniel Lezcano
2014-04-08 12:19 ` [PATCH V3 02/17] ARM: exynos: cpuidle: use cpuidle_register Daniel Lezcano
2014-04-08 12:19 ` [PATCH V3 03/17] ARM: exynos: cpuidle: change function name prefix Daniel Lezcano
2014-04-08 12:19 ` [PATCH V3 04/17] ARM: exynos: cpuidle: encapsulate register access inside a function Daniel Lezcano
2014-04-08 12:19 ` [PATCH V3 05/17] ARM: exynos: cpuidle: Move some code inside the idle_finisher Daniel Lezcano
2014-04-08 12:19 ` [PATCH V3 06/17] ARM: exynos: cpuidle: Fix S5P_WAKEUP_STAT call Daniel Lezcano
2014-04-08 12:19 ` [PATCH V3 07/17] ARM: exynos: cpuidle: Use the cpu_pm notifier Daniel Lezcano
2014-04-08 12:19 ` [PATCH V3 08/17] ARM: exynos: cpuidle: Move scu_enable in " Daniel Lezcano
2014-04-08 12:19 ` [PATCH V3 09/17] ARM: exynos: cpuidle: Remove ifdef for scu_enable Daniel Lezcano
2014-04-08 12:19 ` [PATCH V3 10/17] ARM: exynos: cpuidle: Move exynos_set_wakeupmask in the cpu_pm notifier Daniel Lezcano
2014-04-09 12:14 ` Tomasz Figa
2014-04-08 12:19 ` [PATCH V3 11/17] ARM: exynos: cpuidle: Move the power sequence call " Daniel Lezcano
2014-04-09 12:17 ` Tomasz Figa
2014-04-09 13:33 ` Daniel Lezcano
2014-04-08 12:19 ` [PATCH V3 12/17] ARM: exynos: cpuidle: Move S5P_CHECK_AFTR in a header Daniel Lezcano
2014-04-09 12:21 ` Tomasz Figa [this message]
2014-04-08 12:19 ` [PATCH V3 13/17] ARM: exynos: cpuidle: Move clock setup to pm.c Daniel Lezcano
2014-04-08 12:19 ` [PATCH V3 14/17] ARM: exynos: cpuidle: Move the boot vector in pm.c Daniel Lezcano
2014-04-09 12:27 ` Tomasz Figa
2014-04-08 12:19 ` [PATCH V3 15/17] ARM: exynos: cpuidle: Disable cpuidle for 5440 Daniel Lezcano
[not found] ` <CAP245DUmBVeZqBYDc3mopvs_h5AkcTgjG2eO7z5VAQnUDJJogQ@mail.gmail.com>
2014-04-08 13:21 ` Daniel Lezcano
2014-04-08 19:30 ` Nicolas Pitre
2014-04-08 12:19 ` [PATCH V3 16/17] ARM: exynos: cpuidle: Pass the AFTR callback to the platform_data Daniel Lezcano
2014-04-09 12:29 ` Tomasz Figa
2014-04-08 12:19 ` [PATCH V3 17/17] ARM: exynos: cpuidle: Move the driver to drivers/cpuidle directory Daniel Lezcano
2014-04-09 12:30 ` [PATCH V3 00/17] ARM: exynos: cpuidle: Move the driver to drivers/cpuidle Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53453B4E.8000203@samsung.com \
--to=t.figa@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox