From: t.figa@samsung•com (Tomasz Figa)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/6] ARM: EXYNOS: Staticize exynos_subsys
Date: Thu, 10 Apr 2014 11:17:59 +0200 [thread overview]
Message-ID: <534661C7.9090304@samsung.com> (raw)
In-Reply-To: <1397118296-6846-3-git-send-email-sachin.kamat@linaro.org>
Hi Sachin,
On 10.04.2014 10:24, Sachin Kamat wrote:
> 'exynos_subsys' is now local to this file. Make it static
> and remove the declaration from header file.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro•org>
> ---
> arch/arm/mach-exynos/exynos.c | 2 +-
> arch/arm/plat-samsung/include/plat/cpu.h | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
> index 6a5fe18ec9b1..0ef42b9efd36 100644
> --- a/arch/arm/mach-exynos/exynos.c
> +++ b/arch/arm/mach-exynos/exynos.c
> @@ -284,7 +284,7 @@ void __init exynos_init_io(void)
> of_scan_flat_dt(exynos_fdt_map_sysram, NULL);
> }
>
> -struct bus_type exynos_subsys = {
> +static struct bus_type exynos_subsys = {
> .name = "exynos-core",
> .dev_name = "exynos-core",
> };
> diff --git a/arch/arm/plat-samsung/include/plat/cpu.h b/arch/arm/plat-samsung/include/plat/cpu.h
> index 5992b8dd9b89..930b4be832cd 100644
> --- a/arch/arm/plat-samsung/include/plat/cpu.h
> +++ b/arch/arm/plat-samsung/include/plat/cpu.h
> @@ -239,7 +239,6 @@ extern struct bus_type s3c2443_subsys;
> extern struct bus_type s3c6410_subsys;
> extern struct bus_type s5p64x0_subsys;
> extern struct bus_type s5pv210_subsys;
> -extern struct bus_type exynos_subsys;
>
> extern void (*s5pc1xx_idle)(void);
>
>
This struct and registration of it do not seem to be needed for anything
anymore. Would you consider removing it instead?
Best regards,
Tomasz
next prev parent reply other threads:[~2014-04-10 9:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 8:24 [PATCH 0/6] Further cleanup and enable multiplat build Sachin Kamat
2014-04-10 8:24 ` [PATCH 1/6] ARM: EXYNOS: Remove duplicate lines in Makefile Sachin Kamat
2014-04-10 8:24 ` [PATCH 2/6] ARM: EXYNOS: Staticize exynos_subsys Sachin Kamat
2014-04-10 9:17 ` Tomasz Figa [this message]
2014-04-10 9:22 ` Sachin Kamat
2014-04-10 12:32 ` Tomasz Figa
2014-04-10 12:35 ` Sachin Kamat
2014-04-15 9:06 ` Sachin Kamat
2014-04-10 8:24 ` [PATCH 3/6] ARM: EXYNOS: Migrate Exynos specific macros from plat to mach Sachin Kamat
2014-04-10 8:24 ` [PATCH 4/6] ARM: EXYNOS: Remove unnecessary inclusion of cpu.h Sachin Kamat
2014-04-10 8:24 ` [PATCH 5/6] ARM: EXYNOS: Enable multi-platform build support Sachin Kamat
2014-04-10 8:24 ` [PATCH 6/6] ARM: multi_v7_defconfig: Enable Exynos platform Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534661C7.9090304@samsung.com \
--to=t.figa@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox