From: cw00.choi@samsung•com (Chanwoo Choi)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv2 5/8] ARM: EXYNOS: Support secondary CPU boot of Exynos3250
Date: Thu, 17 Apr 2014 19:15:09 +0900 [thread overview]
Message-ID: <534FA9AD.7000406@samsung.com> (raw)
In-Reply-To: <CAHbNUh3m7n1OT9fc715vth=k6BdAvVZoYJjBvo8xT25TPji18w@mail.gmail.com>
Hi Tushar,
On 04/15/2014 02:09 PM, Tushar Behera wrote:
> On 15 April 2014 07:29, Chanwoo Choi <cw00.choi@samsung•com> wrote:
>> This patch fix the offset of CPU boot address and don't operate smc call
>> of SMC_CMD_CPU1BOOT command for Exynos3250.
>>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung•com>
>> Acked-by: Kyungmin Park <kyungmin.park@samsung•com>
>> ---
>> arch/arm/mach-exynos/firmware.c | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-exynos/firmware.c b/arch/arm/mach-exynos/firmware.c
>> index aa01c42..6205d4f 100644
>> --- a/arch/arm/mach-exynos/firmware.c
>> +++ b/arch/arm/mach-exynos/firmware.c
>> @@ -30,13 +30,16 @@ static int exynos_do_idle(void)
>>
>> static int exynos_cpu_boot(int cpu)
>> {
>> + if (soc_is_exynos3250()) {
>> + return 0;
>> /*
>> * The second parameter of SMC_CMD_CPU1BOOT command means CPU id.
>> * But, Exynos4212 has only one secondary CPU so second parameter
>> * isn't used for informing secure firmware about CPU id.
>> */
>> - if (soc_is_exynos4212())
>> + } else if (soc_is_exynos4212()) {
>> cpu = 0;
>> + }
>>
>
> As you already return in case of Exynos3250, you need not change this.
> First commit hunk without the opening brace should be sufficient.
OK, I'll remove brace.
Best Regards,
Chanwoo Choi
next prev parent reply other threads:[~2014-04-17 10:15 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 1:59 [PATCHv2 0/8] Support new Exynos3250 SoC based on Cortex-A7 dual core Chanwoo Choi
2014-04-15 1:59 ` [PATCHv2 1/8] ARM: EXYNOS: Add Exynos3250 SoC ID Chanwoo Choi
2014-04-15 1:59 ` [PATCHv2 2/8] ARM: EXYNOS: Add IO mapping for non-secure SYSRAM of Exynos3250 Chanwoo Choi
2014-04-15 1:59 ` [PATCHv2 3/8] ARM: EXYNOS: Add IO mapping for PMU " Chanwoo Choi
2014-04-15 8:11 ` Arnd Bergmann
2014-04-15 8:32 ` Chanwoo Choi
2014-04-15 8:39 ` Vikas Sajjan
2014-04-15 8:41 ` Chanwoo Choi
2014-04-15 8:46 ` Arnd Bergmann
2014-04-15 8:51 ` Chanwoo Choi
2014-04-15 1:59 ` [PATCHv2 4/8] ARM: EXYNOS: Support secondary CPU boot of Exynos4212 Chanwoo Choi
2014-04-15 1:59 ` [PATCHv2 5/8] ARM: EXYNOS: Support secondary CPU boot of Exynos3250 Chanwoo Choi
2014-04-15 5:09 ` Tushar Behera
2014-04-17 10:15 ` Chanwoo Choi [this message]
2014-04-16 14:28 ` Tomasz Figa
2014-04-17 8:04 ` Chanwoo Choi
2014-04-15 1:59 ` [PATCHv2 6/8] ARM: EXYNOS: Enter a15 lowpower mode for Exynos3250 based on Cortex-a7 Chanwoo Choi
2014-04-16 14:35 ` Tomasz Figa
2014-04-16 14:39 ` Chanwoo Choi
2014-04-15 1:59 ` [PATCHv2 7/8] clk: samsung: exynos3250: Add clocks using common clock framework Chanwoo Choi
2014-04-15 1:59 ` [PATCHv2 8/8] ARM: dts: Add device tree sources for Exynos3250 Chanwoo Choi
2014-04-15 8:15 ` Marc Zyngier
2014-04-15 8:27 ` Chanwoo Choi
2014-04-15 9:13 ` Marc Zyngier
2014-04-15 9:19 ` Chanwoo Choi
2014-04-15 9:24 ` Marc Zyngier
2014-04-16 8:22 ` Chanwoo Choi
2014-04-16 8:34 ` Marc Zyngier
2014-04-16 8:45 ` Chanwoo Choi
2014-04-16 10:23 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534FA9AD.7000406@samsung.com \
--to=cw00.choi@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox