From: david.vrabel@citrix•com (David Vrabel)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] xen: use sync_clear_bit instead of clear_bit
Date: Thu, 17 Apr 2014 11:23:06 +0100 [thread overview]
Message-ID: <534FAB8A.3090000@citrix.com> (raw)
In-Reply-To: <1397724110-31851-1-git-send-email-murzin.v@gmail.com>
On 17/04/14 09:41, Vladimir Murzin wrote:
> Signed-off-by: Vladimir Murzin <murzin.v@gmail•com>
> ---
> For those who whant to play with original issue [1]
>
> [1] http://www.gossamer-threads.com/lists/xen/devel/325613
>
> drivers/xen/events/events_fifo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/xen/events/events_fifo.c b/drivers/xen/events/events_fifo.c
> index 96109a9..91248d8 100644
> --- a/drivers/xen/events/events_fifo.c
> +++ b/drivers/xen/events/events_fifo.c
> @@ -273,7 +273,7 @@ static void consume_one_event(unsigned cpu,
> * copy of the ready word.
> */
> if (head == 0)
> - clear_bit(priority, BM(ready));
> + sync_clear_bit(priority, BM(ready));
I prefer the fix that makes ready an unsigned long.
David
next prev parent reply other threads:[~2014-04-17 10:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 8:38 [PATCH RFC] arm64: 32-bit tolerant sync bitops Vladimir Murzin
2014-04-17 8:41 ` [PATCH] xen: use sync_clear_bit instead of clear_bit Vladimir Murzin
2014-04-17 10:23 ` David Vrabel [this message]
2014-04-17 10:42 ` [Xen-devel] [PATCH RFC] arm64: 32-bit tolerant sync bitops David Vrabel
2014-04-21 16:18 ` Vladimir Murzin
2014-04-22 10:16 ` David Vrabel
2014-04-22 10:55 ` Ian Campbell
2014-04-23 8:31 ` Ian Campbell
2014-04-22 20:56 ` Vladimir Murzin
2014-04-25 7:17 ` Ian Campbell
2014-04-25 8:43 ` Vladimir Murzin
2014-04-25 8:42 ` Vladimir Murzin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534FAB8A.3090000@citrix.com \
--to=david.vrabel@citrix$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox