From: cw00.choi@samsung•com (Chanwoo Choi)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv3 2/2] iio: devicetree: Add DT binding documentation for Exynos3250 ADC
Date: Thu, 17 Apr 2014 20:52:17 +0900 [thread overview]
Message-ID: <534FC071.9080502@samsung.com> (raw)
In-Reply-To: <534E6E4E.4020807@samsung.com>
Hi Tomasz,
On 04/16/2014 08:49 PM, Tomasz Figa wrote:
> Hi Chanwoo,
>
> On 16.04.2014 12:11, Chanwoo Choi wrote:
>> This patch add DT binding documentation for Exynos3250 ADC IP. Exynos3250 has
>> special clock ('sclk_tsadc') for ADC which provide clock to internal ADC.
>>
>> Cc: Rob Herring <robh+dt@kernel•org>
>> Cc: Pawel Moll <pawel.moll@arm•com>
>> Cc: Mark Rutland <mark.rutland@arm•com>
>> Cc: Ian Campbell <ijc+devicetree@hellion•org.uk>
>> Cc: Kumar Gala <galak@codeaurora•org>
>> Cc: Randy Dunlap <rdunlap@infradead•org>
>> Cc: Kukjin Kim <kgene.kim@samsung•com>
>> Cc: Naveen Krishna Chatradhi <ch.naveen@samsung•com>
>> Cc: Tomasz Figa <t.figa@samsung•com>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung•com>
>> Acked-by: Kyungmin Park <kyungmin.park@samsung•com>
>> ---
>> .../devicetree/bindings/arm/samsung/exynos-adc.txt | 20 ++++++++++++++++++++
>> 1 file changed, 20 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt b/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
>> index 5d49f2b..7532ec3 100644
>> --- a/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
>> +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
>> @@ -14,6 +14,8 @@ Required properties:
>> for exynos4412/5250 controllers.
>> Must be "samsung,exynos-adc-v2" for
>> future controllers.
>> + Must be "samsung,exynos-adc-v3" for
>> + for exynos3250 controllers.
>
> I don't think adc-v3 is correct here. It looks like a normal V2 with additional special clock input. Possibly "samsung,exynos3250-adc-v2" or "samsung,exynos-adc-v2-sclk" would be better choices.
OK, I'll fix it with following compatible
- "samsung,exynos-adc-v2-sclk"
>
>> - reg: Contains ADC register address range (base address and
>> length) and the address of the phy enable register.
>> - interrupts: Contains the interrupt information for the timer. The
>> @@ -21,7 +23,11 @@ Required properties:
>> the Samsung device uses.
>> - #io-channel-cells = <1>; As ADC has multiple outputs
>> - clocks From common clock binding: handle to adc clock.
>> + From common clock binding: handle to sclk_tsadc clock
>> + if using Exynos3250.
>> - clock-names From common clock binding: Shall be "adc".
>> + From common clock binding: Shall be "sclk_tsadc"
>> + if using Exynos3250.
>> - vdd-supply VDD input supply.
>>
>> Note: child nodes can be added for auto probing from device tree.
>> @@ -41,6 +47,20 @@ adc: adc at 12D10000 {
>> vdd-supply = <&buck5_reg>;
>> };
>>
>> +If Exynos3250 uses ADC,
>
> Please keep proper formatting:
>
> Example: Node for ADC of Exynos3250 with additional special clock
Thanks, I'll fix it.
Best regards,
Chanwoo Choi
prev parent reply other threads:[~2014-04-17 11:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 10:11 [PATCHv3 0/2] iio: adc: exynos_adc: Support Exynos3250 ADC Chanwoo Choi
2014-04-16 10:11 ` [PATCHv3 1/2] iio: adc: exynos_adc: Control special clock of ADC to support " Chanwoo Choi
2014-04-16 10:41 ` Tomasz Figa
2014-04-16 10:11 ` [PATCHv3 2/2] iio: devicetree: Add DT binding documentation for " Chanwoo Choi
2014-04-16 11:49 ` Tomasz Figa
2014-04-17 11:52 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534FC071.9080502@samsung.com \
--to=cw00.choi@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox