From: grygorii.strashko@ti•com (Grygorii Strashko)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 4/7] of: configure the platform device dma parameters
Date: Tue, 22 Apr 2014 18:09:53 +0300 [thread overview]
Message-ID: <53568641.2020300@ti.com> (raw)
In-Reply-To: <CAL_JsqJJ4Cbh5poMa-KRwy+bp_t3VtRd7bCpcWey+DZ74eYHJQ@mail.gmail.com>
Hi Rob,
On 04/21/2014 05:58 PM, Rob Herring wrote:
> On Sat, Apr 19, 2014 at 9:32 AM, Santosh Shilimkar
> <santosh.shilimkar@ti•com> wrote:
>> Retrieve DMA configuration from DT and setup platform device's DMA
>> parameters. The DMA configuration in DT has to be specified using
>> "dma-ranges" and "dma-coherent" properties if supported.
>>
>> We setup dma_pfn_offset using "dma-ranges" and dma_coherent_ops
>> using "dma-coherent" device tree properties.
>>
>> The set_arch_dma_coherent_ops macro has to be defined by arch if
>> it supports coherent dma_ops. Otherwise, set_arch_dma_coherent_ops() is
>> declared as nop.
>>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
>> Cc: Russell King <linux@arm•linux.org.uk>
>> Cc: Arnd Bergmann <arnd@arndb•de>
>> Cc: Olof Johansson <olof@lixom•net>
>> Cc: Grant Likely <grant.likely@linaro•org>
>> Cc: Rob Herring <robh+dt@kernel•org>
>> Cc: Catalin Marinas <catalin.marinas@arm•com>
>> Cc: Linus Walleij <linus.walleij@linaro•org>
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti•com>
>> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti•com>
>> ---
>> drivers/of/platform.c | 43 +++++++++++++++++++++++++++++++++++++++++++
>> include/linux/dma-mapping.h | 7 +++++++
>> 2 files changed, 50 insertions(+)
>>
>> diff --git a/drivers/of/platform.c b/drivers/of/platform.c
>> index 573db15..7e4a43b 100644
>> --- a/drivers/of/platform.c
>> +++ b/drivers/of/platform.c
>> @@ -187,6 +187,47 @@ struct platform_device *of_device_alloc(struct device_node *np,
>> EXPORT_SYMBOL(of_device_alloc);
>>
>> /**
>> + * of_dma_configure - Setup DMA configuration
>> + * @dev: Device to apply DMA configuration
>> + *
>> + * Try to get devices's DMA configuration from DT and update it
>> + * accordingly.
>> + *
>> + * In case if platform code need to use own special DMA configuration,it
>> + * can use Platform bus notifier and handle BUS_NOTIFY_ADD_DEVICE event
>> + * to fix up DMA configuration.
>> + */
>> +static void of_dma_configure(struct device *dev)
>> +{
>> + dma_addr_t dma_addr;
>> + phys_addr_t paddr, size;
>
> A problem with using dma_addr_t and phys_addr_t is that they normally
> depend on CONFIG_LPAE, but the address cell sizes are independent of
> that. That is why all the memory related functions stick with u64. I
> think you would have issues here if you have a platform with sizes of
> 4GB or more. You need to properly cap the sizes and addresses.
>
>> + int ret;
>> +
>> + /*
>> + * if dma-coherent property exist, call arch hook to setup
>> + * dma coherent operations.
>> + */
>> + if (of_dma_is_coherent(dev->of_node)) {
>> + set_arch_dma_coherent_ops(dev);
>> + dev_dbg(dev, "device is dma coherent\n");
>> + }
>> +
>> + /*
>> + * if dma-ranges property doesn't exist - just return else
>> + * setup the dma offset
>> + */
>> + ret = of_dma_get_range(dev->of_node, &dma_addr, &paddr, &size);
>> + if (ret < 0) {
>
> Perhaps an error is not the right return for the default case. The
> default should probably be dma_addr and paddr equal to 0 and size 4GB.
The error code is needed here to properly distinguish the case when
there are no "dma-ranges" defined in DT. Also, I think, that
of_dma_get_range() shouldn't return any default values - It just
has to get data from DT. And the caller should decide what to do
with this data and how to handle error cases.
So, I prefer to keep behavior as is:
- in case of failure of_dma_get_range() will not touch values of
&dma_addr, &paddr, &size.
>
>> + dev_dbg(dev, "no dma range information to setup\n");
>> + return;
>> + } else {
>
> You don't need the else here.
>
[...]
Thanks for your comments.
Regards,
-Grygorii
next prev parent reply other threads:[~2014-04-22 15:09 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-19 14:32 [PATCH v2 0/7] of: setup dma parameters using dma-ranges and dma-coherent Santosh Shilimkar
2014-04-19 14:32 ` [PATCH v2 1/7] device: introduce per device dma_pfn_offset Santosh Shilimkar
2014-04-19 14:32 ` [PATCH v2 2/7] of: introduce of_dma_get_range() helper Santosh Shilimkar
2014-04-21 15:29 ` Rob Herring
2014-04-22 14:56 ` Grygorii Strashko
2014-04-22 4:09 ` Joel Fernandes
2014-04-19 14:32 ` [PATCH v2 3/7] of: introduce of_dma_is_coherent() helper Santosh Shilimkar
2014-04-19 14:32 ` [PATCH v2 4/7] of: configure the platform device dma parameters Santosh Shilimkar
2014-04-21 14:58 ` Rob Herring
2014-04-22 15:09 ` Grygorii Strashko [this message]
2014-04-22 14:44 ` Rob Herring
2014-04-22 15:44 ` Grygorii Strashko
2014-04-19 14:32 ` [PATCH v2 5/7] ARM: dma: Use dma_pfn_offset for dma address translation Santosh Shilimkar
2014-04-19 19:43 ` Russell King - ARM Linux
2014-04-21 13:38 ` Santosh Shilimkar
2014-04-19 14:32 ` [PATCH v2 6/7] ARM: dma: implement set_arch_dma_coherent_ops() Santosh Shilimkar
2014-04-19 14:32 ` [PATCH v2 7/7] ARM: mm: use phys_addr_t in __dma_page_[cpu_to_dev/dev_to_cpu] Santosh Shilimkar
2014-04-21 13:39 ` Santosh Shilimkar
2014-04-19 16:25 ` [PATCH v2 0/7] of: setup dma parameters using dma-ranges and dma-coherent Thomas Petazzoni
2014-04-21 13:35 ` Santosh Shilimkar
2014-04-21 18:19 ` Thomas Petazzoni
2014-04-21 19:17 ` Santosh Shilimkar
2014-04-22 14:54 ` Catalin Marinas
2014-04-22 15:02 ` Arnd Bergmann
2014-04-22 15:15 ` Santosh Shilimkar
2014-04-22 15:25 ` Catalin Marinas
2014-04-22 15:30 ` Rob Herring
2014-04-22 16:01 ` Catalin Marinas
2014-04-21 14:37 ` Rob Herring
2014-04-21 15:13 ` Santosh Shilimkar
2014-04-21 15:35 ` Rob Herring
2014-04-21 15:36 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53568641.2020300@ti.com \
--to=grygorii.strashko@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox