From: tomi.valkeinen@ti•com (Tomi Valkeinen)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/2] omapdss: panel-tpo-td028ec1: Add DT support.
Date: Wed, 23 Apr 2014 13:44:47 +0300 [thread overview]
Message-ID: <5357999F.6010200@ti.com> (raw)
In-Reply-To: <1398201168-25275-2-git-send-email-marek@goldelico.com>
On 23/04/14 00:12, Marek Belisko wrote:
> static int td028ttec1_panel_probe(struct spi_device *spi)
> {
> struct panel_drv_data *ddata;
> @@ -418,6 +436,10 @@ static int td028ttec1_panel_probe(struct spi_device *spi)
> r = td028ttec1_panel_probe_pdata(spi);
> if (r)
> return r;
> + } else if (spi->dev.of_node) {
> + r = td028ttec1_probe_of(spi);
> + if (r)
> + return r;
> } else {
> return -ENODEV;
> }
> @@ -463,6 +485,13 @@ static int td028ttec1_panel_remove(struct spi_device *spi)
> return 0;
> }
>
> +static const struct of_device_id td028ttec1_of_match[] = {
> + { .compatible = "toppoly,td028ttec1", },
We need to hack a bit here for the time being. You need to have
"omapdss," prefix for the compatible string in the driver, and add the
panel's compatible string to arch/arm/mach-omap2/display.c:
dss_compat_conv_list.
The reason for this is that the drivers are omap specific, but the DT
data is not.
Otherwise looks good to me.
Tomi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140423/b05ffe8d/attachment.sig>
next prev parent reply other threads:[~2014-04-23 10:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 21:12 [PATCH 0/2] Add display support for gta04 device Marek Belisko
2014-04-22 21:12 ` [PATCH 1/2] omapdss: panel-tpo-td028ec1: Add DT support Marek Belisko
2014-04-23 10:44 ` Tomi Valkeinen [this message]
2014-04-22 21:12 ` [PATCH 2/2] ARM: dts: oma3-gta04: Add display support Marek Belisko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5357999F.6010200@ti.com \
--to=tomi.valkeinen@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox