From: t.figa@samsung•com (Tomasz Figa)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/4] ARM: dts: exynos4: add hsotg device node
Date: Thu, 24 Apr 2014 18:16:37 +0200 [thread overview]
Message-ID: <535938E5.5020204@samsung.com> (raw)
In-Reply-To: <1397479700-15864-4-git-send-email-chanho61.park@samsung.com>
Hi Chanho,
On 14.04.2014 14:48, Chanho Park wrote:
> This patch adds a hsotg node for exynos4 USB2.0 device controller.
>
> Cc: Tomasz Figa <t.figa@samsung•com>
> Cc: Kamil Debski <k.debski@samsung•com>
> Cc: Marek Szyprowski <m.szyprowski@samsung•com>
> Signed-off-by: Chanho Park <chanho61.park@samsung•com>
> ---
> arch/arm/boot/dts/exynos4.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index 0e32d7f..e541ecb 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -288,6 +288,17 @@
> #phy-cells = <1>;
> };
>
> + hsotg at 12480000 {
> + compatible = "samsung,s3c6400-hsotg";
> + reg = <0x12480000 0x20000>;
> + interrupts = <0 71 0>;
> + clocks = <&clock 305>;
Please use clock macros.
> + clock-names = "otg";
> + phys = <&exynos_usbphy 0>;
> + phy-names = "device";
This is not the correct phy name for this binding. According to what the
driver uses and the example in ...bindings/usb/dwc2.txt "usb2-phy"
should be used.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-04-24 16:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 12:48 [PATCH 0/4] Enable usbphy and hsotg for exynos4 Chanho Park
2014-04-14 12:48 ` [PATCH 1/4] ARM: dts: exynos4: add PMU syscon node Chanho Park
2014-04-24 16:07 ` Tomasz Figa
2014-04-25 8:05 ` Vikas Sajjan
2014-04-25 23:52 ` Tomasz Figa
2014-04-26 2:33 ` Pankaj Dubey
2014-04-14 12:48 ` [PATCH 2/4] ARM: dts: exynos4: add exynos_usbphy node Chanho Park
2014-04-24 16:09 ` Tomasz Figa
2014-04-14 12:48 ` [PATCH 3/4] ARM: dts: exynos4: add hsotg device node Chanho Park
2014-04-24 16:16 ` Tomasz Figa [this message]
2014-04-14 12:48 ` [PATCH 4/4] ARM: dts: exynos4412-trats2: enable usb nodes Chanho Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535938E5.5020204@samsung.com \
--to=t.figa@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox