From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 33/38] mmc: sdhci: fix SDHCI dependencies
Date: Mon, 28 Apr 2014 10:28:49 -0600 [thread overview]
Message-ID: <535E81C1.3020902@wwwdotorg.org> (raw)
In-Reply-To: <E1Wd2XT-0003wV-0H@rmk-PC.arm.linux.org.uk>
On 04/23/2014 01:08 PM, Russell King wrote:
> Signed-off-by: Russell King <rmk+kernel@arm•linux.org.uk>
A patch description would be useful so I can work out why...
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> config MMC_SDHCI
> - tristate "Secure Digital Host Controller Interface support"
> - depends on HAS_DMA
> + tristate
> help
> This selects the generic Secure Digital Host Controller Interface.
> It is used by manufacturers such as Texas Instruments(R), Ricoh(R)
... it's useful to remove that depends from here and ...
> config MMC_SDHCI_TEGRA
> tristate "SDHCI platform support for the Tegra SD/MMC Controller"
> - depends on ARCH_TEGRA
> - depends on MMC_SDHCI_PLTFM
> + depends on ARCH_TEGRA && HAS_DMA
... duplicate it in all the HW-specific drivers.
On Tegra (and I believe at least any ARM system), I think HAS_DMA is
always true, so is there a need for "&& HAS_DMA" at all, now that this
statement is pushed into arch-/HW-specific options?
next prev parent reply other threads:[~2014-04-28 16:28 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 18:55 [PATCH 00/38] MMC updates, plus CuBox-i WiFi support Russell King - ARM Linux
2014-04-23 19:06 ` [PATCH 01/38] mmc: sdio_irq: rework sdio irq handling Russell King
2014-04-24 7:58 ` Ulf Hansson
2014-04-24 8:46 ` Russell King - ARM Linux
2014-04-24 8:58 ` Ulf Hansson
2014-04-23 19:06 ` [PATCH 02/38] mmc: sdhci: clean up interrupt handling Russell King
2014-04-23 19:06 ` [PATCH 03/38] mmc: sdhci: clean up sdio interrupt enable handling Russell King
2014-04-23 19:06 ` [PATCH 04/38] mmc: sdhci: convert to new SDIO IRQ handling Russell King
2014-04-23 19:06 ` [PATCH 05/38] mmc: sdhci: push card_tasklet into threaded irq handler Russell King
2014-04-23 19:06 ` [PATCH 06/38] mmc: sdhci: allow sdio interrupts while sdhci runtime suspended Russell King
2014-04-23 19:06 ` [PATCH 07/38] mmc: sdhci: more efficient interrupt enable register handling Russell King
2014-04-23 19:06 ` [PATCH 08/38] mmc: sdhci: plug hole in disabling card detection interrupts Russell King
2014-04-23 19:06 ` [PATCH 09/38] mmc: sdhci: convert generic bus width setup to library function Russell King
2014-04-23 19:07 ` [PATCH 10/38] mmc: sdhci: convert reset into a " Russell King
2014-04-23 19:07 ` [PATCH 11/38] mmc: sdhci: move FSL ESDHC reset handling quirk into esdhc code Russell King
2014-04-23 19:07 ` [PATCH 12/38] mmc: sdhci: avoid sync'ing the SG if there's no misalignment Russell King
2014-04-23 19:07 ` [PATCH 13/38] mmc: sdhci: convert ADMA descriptors to a coherent allocation Russell King
2014-04-23 19:07 ` [PATCH 14/38] mmc: sdhci: clean up sdhci_update_clock()/sdhci_set_clock() Russell King
2014-04-23 19:07 ` [PATCH 15/38] mmc: sdhci: move setting host->clock into sdhci_do_set_ios() Russell King
2014-04-23 19:07 ` [PATCH 16/38] mmc: sdhci: move setting mmc->actual_clock into set_clock handlers Russell King
2014-04-23 19:07 ` [PATCH 17/38] mmc: sdhci: convert sdhci_set_clock() into a library function Russell King
2014-04-23 19:07 ` [PATCH 18/38] mmc: sdhci-esdhc-imx: avoid DMA to kernel stack Russell King
2014-04-23 19:07 ` [PATCH 19/38] mmc: sdhci-esdhc-imx: comment runtime_pm_get_sync() in esdhc_prepare_tuning() Russell King
2014-04-23 19:07 ` [PATCH 20/38] mmc: sdhci-esdhc-imx: fix lockdep splat upon tuning Russell King
2014-04-23 19:07 ` [PATCH 21/38] mmc: sdhci: hack up driver to make it more compliant with UHS-1 Russell King
2014-04-25 12:38 ` Markus Pargmann
2014-04-25 12:49 ` Russell King - ARM Linux
2014-04-25 13:08 ` Markus Pargmann
2014-04-25 13:15 ` Russell King - ARM Linux
2014-04-25 13:22 ` Russell King - ARM Linux
2014-04-25 13:26 ` [PATCH 22/32] mmc: sdhci: convert sdhci_set_uhs_signaling() into a library function Russell King
2014-04-28 13:10 ` [PATCH 21/38] mmc: sdhci: hack up driver to make it more compliant with UHS-1 Markus Pargmann
2014-04-25 16:20 ` Russell King - ARM Linux
2014-04-28 10:50 ` Ulf Hansson
2014-04-28 11:02 ` Russell King - ARM Linux
2014-04-28 11:11 ` Ulf Hansson
2014-04-28 11:51 ` Russell King - ARM Linux
2014-04-23 19:08 ` [PATCH 22/38] mmc: sdhci: set_uhs_signaling() need not return a value Russell King
2014-04-23 19:08 ` [PATCH 23/38] mmc: sdhci: convert sdhci_set_uhs_signaling() into a library function Russell King
2014-06-16 10:46 ` Russell King - ARM Linux
2014-06-16 12:17 ` Ulf Hansson
2014-06-16 16:10 ` Ulf Hansson
2014-06-17 23:42 ` Russell King - ARM Linux
2014-06-19 12:28 ` Russell King - ARM Linux
2014-06-19 15:57 ` Stephen Warren
2014-06-19 17:02 ` Olof Johansson
2014-04-23 19:08 ` [PATCH 24/38] mmc: sdhci: cache timing information locally Russell King
2014-04-23 19:08 ` [PATCH 25/38] mmc: sdhci: clean up sdhci_execute_tuning() decision Russell King
2014-04-23 19:08 ` [PATCH 26/38] mmc: sdhci-esdhc-imx: remove emulation of uhs_mode Russell King
2014-04-23 19:08 ` [PATCH 27/38] mmc: sdhci-of-esdhc: remove platform_suspend/platform_resume callbacks Russell King
2014-04-24 7:32 ` Ulf Hansson
2014-04-24 11:18 ` Russell King - ARM Linux
2014-04-24 11:32 ` Ulf Hansson
2014-04-24 12:27 ` Russell King - ARM Linux
2014-04-24 13:15 ` Ulf Hansson
2014-04-23 19:08 ` [PATCH 28/38] mmc: sdhci: " Russell King
2014-04-24 7:33 ` Ulf Hansson
2014-04-23 19:08 ` [PATCH 29/38] mmc: sdhci-tegra: get rid of special PRESENT_STATE register handling Russell King
2014-04-23 19:08 ` [PATCH 30/38] mmc: sdhci: move regulator handling into sdhci_set_power() Russell King
2014-04-23 19:08 ` [PATCH 31/38] mmc: sdhci: move remaining power " Russell King
2014-04-23 19:08 ` [PATCH 32/38] mmc: sdhci: track whether preset mode is currently enabled in hardware Russell King
2014-04-23 19:08 ` [PATCH 33/38] mmc: sdhci: fix SDHCI dependencies Russell King
2014-04-28 16:28 ` Stephen Warren [this message]
2014-04-23 19:09 ` [PATCH 34/38] mmc: add support for power-on sequencing through DT Russell King
2014-04-24 9:05 ` Maxime Ripard
2014-04-23 19:09 ` [PATCH 35/38] mmc: dw_mmc: call mmc_of_parse to fill in common options Russell King
2014-04-24 0:31 ` Jaehoon Chung
2014-04-24 19:42 ` Russell King - ARM Linux
2014-04-23 19:09 ` [PATCH 36/38] mmc: fix power-on sequencing for esdhc-imx driver Russell King
2014-04-23 19:09 ` [PATCH 37/38] ARM: cubox-i: add support for SD UHS-1 cards Russell King
2014-04-23 19:09 ` [PATCH 38/38] ARM: cubox-i: add support for Wifi/BT Russell King
2014-04-24 8:25 ` [PATCH 00/38] MMC updates, plus CuBox-i WiFi support Ulf Hansson
2014-04-24 10:17 ` Russell King - ARM Linux
2014-04-24 10:52 ` Ulf Hansson
2014-04-24 10:57 ` Russell King - ARM Linux
2014-04-24 11:13 ` Ulf Hansson
2014-04-25 9:03 ` Russell King - ARM Linux
2014-04-25 11:18 ` Ulf Hansson
2014-04-25 11:20 ` Russell King - ARM Linux
2014-04-25 11:40 ` Ulf Hansson
2014-04-28 16:42 ` Stephen Warren
2014-04-28 16:52 ` Chris Ball
2014-05-07 20:49 ` Tim Kryger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535E81C1.3020902@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox