From: george.cherian@ti•com (George Cherian)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2] ARM: dts: am33xx: Move the cppi41dma node so it's probed early
Date: Tue, 29 Apr 2014 13:28:29 +0530 [thread overview]
Message-ID: <535F5BA5.6000903@ti.com> (raw)
In-Reply-To: <CAGm1_kvHtSLNEfkJ24xZGGzsqAjHDTM1XztnX-QGs4iM5voMUw@mail.gmail.com>
On 4/29/2014 11:49 AM, Yegor Yefremov wrote:
> On Thu, Apr 24, 2014 at 11:11 PM, Ezequiel Garcia
> <ezequiel@vanguardiasur•com.ar> wrote:
>> The DMA controller is needed for the USB controller to be correctly
>> registered. Therefore, if the DMA node is located at the end an unecessary
>> probe deferral is produced systematically.
>>
>> This is easily fixed by moving the node at the beggining of the child list,
>> so it's probed first.
This will give issues on module removal.
Since we use device_for_each_child in remove patch, it will try to
remove cppi dma controller, while the channel
is still in use by musb node.
>> Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur•com.ar>
> Tested-by: Yegor Yefremov <yegorslists@googlemail•com>
>
>> --
>> v1->v2:
>> * Added a comment to prevent a future clean-up based on the memory offset.
>>
>> arch/arm/boot/dts/am33xx.dtsi | 34 ++++++++++++++++++++--------------
>> 1 file changed, 20 insertions(+), 14 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
>> index 9770e35..02e1eb6 100644
>> --- a/arch/arm/boot/dts/am33xx.dtsi
>> +++ b/arch/arm/boot/dts/am33xx.dtsi
>> @@ -453,6 +453,26 @@
>> ti,hwmods = "usb_otg_hs";
>> status = "disabled";
>>
>> + /*
>> + * The probe order matches the child ordering so the
>> + * dma-controller node must be the first one to prevent
>> + * spurious probe deferrals.
>> + */
>> + cppi41dma: dma-controller at 47402000 {
>> + compatible = "ti,am3359-cppi41";
>> + reg = <0x47400000 0x1000
>> + 0x47402000 0x1000
>> + 0x47403000 0x1000
>> + 0x47404000 0x4000>;
>> + reg-names = "glue", "controller", "scheduler", "queuemgr";
>> + interrupts = <17>;
>> + interrupt-names = "glue";
>> + #dma-cells = <2>;
>> + #dma-channels = <30>;
>> + #dma-requests = <256>;
>> + status = "disabled";
>> + };
>> +
>> usb_ctrl_mod: control at 44e10620 {
>> compatible = "ti,am335x-usb-ctrl-module";
>> reg = <0x44e10620 0x10
>> @@ -556,20 +576,6 @@
>> "tx14", "tx15";
>> };
>>
>> - cppi41dma: dma-controller at 47402000 {
>> - compatible = "ti,am3359-cppi41";
>> - reg = <0x47400000 0x1000
>> - 0x47402000 0x1000
>> - 0x47403000 0x1000
>> - 0x47404000 0x4000>;
>> - reg-names = "glue", "controller", "scheduler", "queuemgr";
>> - interrupts = <17>;
>> - interrupt-names = "glue";
>> - #dma-cells = <2>;
>> - #dma-channels = <30>;
>> - #dma-requests = <256>;
>> - status = "disabled";
>> - };
>> };
>>
>> epwmss0: epwmss at 48300000 {
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>> the body of a message to majordomo at vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
-George
next prev parent reply other threads:[~2014-04-29 7:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 21:11 [PATCH v2] ARM: dts: am33xx: Move the cppi41dma node so it's probed early Ezequiel Garcia
2014-04-29 6:19 ` Yegor Yefremov
2014-04-29 7:58 ` George Cherian [this message]
2014-04-29 8:06 ` Sebastian Andrzej Siewior
2014-04-29 8:27 ` George Cherian
2014-04-29 9:09 ` Sebastian Andrzej Siewior
2014-04-29 13:50 ` Ezequiel García
2014-05-08 17:00 ` Ezequiel García
2014-05-09 6:22 ` George Cherian
2014-05-09 7:25 ` Sebastian Andrzej Siewior
2014-05-09 10:07 ` George Cherian
2014-05-09 13:26 ` Ezequiel García
2014-05-12 4:59 ` George Cherian
2014-05-12 14:02 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535F5BA5.6000903@ti.com \
--to=george.cherian@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox