From: t.stanislaws@samsung•com (Tomasz Stanislawski)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 0/2] Add support for sii9234 chip
Date: Mon, 05 May 2014 16:15:03 +0200 [thread overview]
Message-ID: <53679CE7.3070202@samsung.com> (raw)
In-Reply-To: <20140503231726.GA20212@kroah.com>
On 05/04/2014 01:17 AM, Greg KH wrote:
> On Fri, Apr 11, 2014 at 01:48:28PM +0200, Tomasz Stanislawski wrote:
>> Hi everyone,
>> This patchset adds support for sii9234 HD Mobile Link Bridge. The chip is used
>> to convert HDMI signal into MHL. The driver enables HDMI output on Trats and
>> Trats2 boards.
>>
>> The code is based on the driver [1] developed by:
>> Adam Hampson <ahampson@sta•samsung.com>
>> Erik Gilling <konkers@android•com>
>> with additional contributions from:
>> Shankar Bandal <shankar.b@samsung•com>
>> Dharam Kumar <dharam.kr@samsung•com>
>>
>> The drivers architecture was greatly simplified and transformed into a form
>> accepted (hopefully) by opensource community. The main differences from
>> original code are:
>> * using single I2C client instead of 4 subclients
>> * remove all logic non-related to establishing HDMI link
>> * simplify error handling
>> * rewrite state machine in interrupt handler
>> * wakeup and discovery triggered by an extcon event
>> * integrate with Device Tree
>>
>> For now, the driver is added to drivers/misc/ directory because it has neigher
>> userspace nor kernel interface. The chip is capable of receiving and
>> processing CEC events, so the driver may export an input device in /dev/ in the
>> future. However CEC could be also handled by HDMI driver.
>>
>> I kindly ask for suggestions about the best location for this driver.
>
> It really is an extcon driver, so why not put it in drivers/extcon? And
> that might solve any build issues you have if you don't select extcon in
> your .config file and try to build this code :)
>
> thanks,
Hi Greg,
Thank you for your comments.
As I understand, drivers/extcon contains only extcon providers.
This driver is an extcon client, so mentioned location may not be adequate.
I am surprised that there are no comments about this driver.
Sii9234 chip is present on many exynos based boards/phones
and HDMI subsystem will not work without this code.
Regards,
Tomasz Stanislawski
>
> greg k-h
>
prev parent reply other threads:[~2014-05-05 14:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 11:48 [PATCH 0/2] Add support for sii9234 chip Tomasz Stanislawski
2014-04-11 11:48 ` [PATCH 1/2] misc: add sii9234 driver Tomasz Stanislawski
2014-05-03 23:17 ` Greg KH
2014-04-11 11:48 ` [PATCH 2/2] arm: dts: trats2: add SiI9234 node Tomasz Stanislawski
2014-05-03 23:17 ` [PATCH 0/2] Add support for sii9234 chip Greg KH
2014-05-05 14:15 ` Tomasz Stanislawski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53679CE7.3070202@samsung.com \
--to=t.stanislaws@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox