From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v1 1/2] arm64: Fix machine_shutdown() definition
Date: Wed, 07 May 2014 09:43:29 -0600 [thread overview]
Message-ID: <536A54A1.8060405@wwwdotorg.org> (raw)
In-Reply-To: <1399426883-13779-1-git-send-email-arunks.linux@gmail.com>
On 05/06/2014 07:41 PM, arunks.linux at gmail.com wrote:
> From: Arun KS <arun.linux@gmail•com>
>
> This patch ports most of commit 19ab428f4b79 "ARM: 7759/1: decouple CPU
> offlining from reboot/shutdown" by Stephen Warren from arch/arm to
> arch/arm64.
>
> machine_shutdown() is a hook for kexec. Add a comment saying so, since
> it isn't obvious from the function name.
>
> Halt, power-off, and restart have different requirements re: stopping
> secondary CPUs than kexec has. The former simply require the secondary
> CPUs to be quiesced somehow, whereas kexec requires them to be
> completely non-operational, so that no matter where the kexec target
> images are written in RAM, they won't influence operation of the
> secondary CPUS,which could happen if the CPUs were still executing some
> kind of pin loop. To this end, modify machine_halt, power_off, and
> restart to call smp_send_stop() directly, rather than calling
> machine_shutdown().
>
> In machine_shutdown(), replace the call to smp_send_stop() with a call
> to disable_nonboot_cpus(). This completely disables all but one CPU,
> thus satisfying the kexec requirements a couple paragraphs above.
I assume the code changes apply equally well to arm64 so,
Acked-by: Stephen Warren <swarren@nvidia•com>
next prev parent reply other threads:[~2014-05-07 15:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 1:41 [PATCH v1 1/2] arm64: Fix machine_shutdown() definition arunks.linux at gmail.com
2014-05-07 1:41 ` [PATCH v1 2/2] arm64: Fix deadlock scenario with smp_send_stop() arunks.linux at gmail.com
2014-05-07 15:43 ` Stephen Warren [this message]
2014-05-16 17:20 ` [PATCH v1 1/2] arm64: Fix machine_shutdown() definition Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536A54A1.8060405@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox