From: boris.brezillon@free-electrons•com (Boris BREZILLON)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 5/7] clk: sunxi: add PRCM (Power/Reset/Clock Management) clks support
Date: Wed, 07 May 2014 19:12:30 +0200 [thread overview]
Message-ID: <536A697E.5000107@free-electrons.com> (raw)
In-Reply-To: <20140428234039.GT3134@lukather>
On 29/04/2014 01:40, Maxime Ripard wrote:
> On Mon, Apr 28, 2014 at 04:58:48PM +0200, Boris BREZILLON wrote:
>> The PRCM (Power/Reset/Clock Management) unit provides several clock
>> devices:
>> - AR100 clk: used to clock the Power Management co-processor
>> - AHB0 clk: used to clock the AHB0 bus
>> - APB0 clk and gates: used to clk
> Used to clk?
"Used to clk peripherals connected on the APB0 bus"
I'll add the missing words in the next version :-).
>
[...]
> Ditto.
>
> And you'll probably want to use devm_ioremap_resource when you'll have
> a single clock for the AR100.
Absolutely.
>
>> +
>> + clk_parent = of_clk_get_parent_name(np, 0);
>> + if (!clk_parent)
>> + return -EINVAL;
[...]
>> +
>> +static struct platform_driver sun6i_a31_prcm_clk_driver = {
>> + .driver = {
>> + .name = "sun6i-a31-prcm-clk",
>> + .owner = THIS_MODULE,
>> + .of_match_table = sun6i_a31_prcm_clk_dt_ids,
>> + },
>> + .probe = sun6i_a31_prcm_clk_probe,
> You're not calling the of_clk_del_provider, and you should probably
> unregister your clocks too.
This driver cannot be compiled as a module, and as a result the probed
clks will never be removed.
Do you really want to support clk removal for this HW block ?
Best Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-05-07 17:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 14:58 [PATCH 0/7] mfd: add basic sun6i A31 PRCM support Boris BREZILLON
2014-04-28 14:58 ` [PATCH 1/7] reset: sunxi: document sunxi's reset controllers bindings Boris BREZILLON
2014-04-28 23:22 ` Maxime Ripard
2014-04-28 14:58 ` [PATCH 2/7] reset: sunxi: allow MFD subdevices probe Boris BREZILLON
2014-04-28 23:27 ` Maxime Ripard
2014-04-28 14:58 ` [PATCH 3/7] mfd: add support for sun6i PRCM (Power/Reset/Clock Management) unit Boris BREZILLON
2014-04-28 23:29 ` Maxime Ripard
2014-04-28 14:58 ` [PATCH 4/7] mfd: sun6i-prcm: document DT bindings Boris BREZILLON
2014-04-28 23:31 ` Maxime Ripard
2014-04-28 14:58 ` [PATCH 5/7] clk: sunxi: add PRCM (Power/Reset/Clock Management) clks support Boris BREZILLON
2014-04-28 15:25 ` Emilio López
2014-04-28 16:01 ` Boris BREZILLON
2014-04-28 15:59 ` Chen-Yu Tsai
2014-04-28 17:14 ` Boris BREZILLON
2014-04-28 18:03 ` Chen-Yu Tsai
2014-04-28 18:19 ` Boris BREZILLON
2014-04-28 23:40 ` Maxime Ripard
2014-05-07 17:12 ` Boris BREZILLON [this message]
2014-05-08 2:45 ` Maxime Ripard
2014-04-28 14:58 ` [PATCH 6/7] clk: sunxi: document PRCM clock compatible strings Boris BREZILLON
2014-04-28 14:58 ` [PATCH 7/7] ARM: sunxi: dt: add PRCM clk and reset controller subdevices Boris BREZILLON
2014-04-28 16:02 ` Chen-Yu Tsai
2014-04-28 17:27 ` Boris BREZILLON
2014-04-28 17:57 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536A697E.5000107@free-electrons.com \
--to=boris.brezillon@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox