From: ipaton0@gmail•com (Iain Paton)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2] ARM: dts: imx6: add new board RIoTboard
Date: Thu, 08 May 2014 15:36:04 +0100 [thread overview]
Message-ID: <536B9654.7020509@gmail.com> (raw)
In-Reply-To: <CAOMZO5AMf74btETX9zM97B-rCRAVh9-s=N4=xqTMifuucwqURg@mail.gmail.com>
On 08/05/14 14:45, Fabio Estevam wrote:
> On Thu, May 8, 2014 at 6:13 AM, Iain Paton <ipaton0@gmail•com> wrote:
>> add element14s RIoTboard http://www.riotboard.org which is an i.MX6Solo
>> based design targeted at makers.
>>
>> Signed-off-by: Iain Paton<ipaton0@gmail•com>
>
> Looks good. One comment only:
>
>
>> +&i2c4 {
>> + clock-frequency = <100000>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_i2c4>;
>> + clocks = <&clks 116>;
>
> You could remove this 'clocks' line.
>
I don't see how.
https://git.kernel.org/cgit/linux/kernel/git/shawnguo/linux.git/tree/arch/arm/boot/dts/imx6dl.dtsi?h=for-next
has the definition of i2c4 as
aips2: aips-bus at 02100000 {
i2c4: i2c at 021f8000 {
#address-cells = <1>;
#size-cells = <0>;
compatible = "fsl,imx1-i2c";
reg = <0x021f8000 0x4000>;
interrupts = <0 35 IRQ_TYPE_LEVEL_HIGH>;
status = "disabled";
};
};
as it has no clocks line I need to add one somewhere otherwise the driver
won't bind to i2c4.
The missing clocks line was something I'd ran into earlier which led to this
https://git.kernel.org/cgit/linux/kernel/git/shawnguo/linux.git/commit/?h=for-next&id=22f5176336b4fc859b8b16211bdfe079405a778f
If it's preferable to put the clocks line in imx6dl.dtsi then I can do
it there instead.
Seperate patch to be applied before the RIoTboard one would be best?
Iain
next prev parent reply other threads:[~2014-05-08 14:36 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 22:03 [RFC PATCH] ARM: dts: imx6: add new board RIoTboard Iain Paton
2014-05-08 2:27 ` Fabio Estevam
2014-05-08 9:10 ` Iain Paton
2014-05-08 5:41 ` Shawn Guo
2014-05-08 9:09 ` Iain Paton
2014-05-08 9:13 ` [PATCH v2] " Iain Paton
2014-05-08 13:45 ` Fabio Estevam
2014-05-08 13:54 ` Alexander Shiyan
2014-05-08 14:36 ` Iain Paton [this message]
2014-05-08 14:50 ` Alexander Shiyan
2014-05-08 17:12 ` Iain Paton
2014-05-08 17:32 ` Alexander Shiyan
2014-05-08 19:27 ` Iain Paton
2014-05-08 19:37 ` Alexander Shiyan
2014-05-09 2:19 ` Shawn Guo
2014-05-09 3:09 ` Shawn Guo
2014-05-09 7:48 ` Iain Paton
2014-05-09 12:08 ` Shawn Guo
2014-05-09 14:16 ` Iain Paton
2014-05-09 14:21 ` Shawn Guo
2014-05-09 15:01 ` [PATCH v3 1/2] ARM: dts: imx6: i2c4 cleanup Iain Paton
2014-05-09 15:30 ` Fabio Estevam
2014-05-10 6:28 ` Shawn Guo
2014-05-09 15:02 ` [PATCH v3 2/2] ARM: dts: imx6: add new board RIoTboard Iain Paton
2014-05-09 15:31 ` Fabio Estevam
2014-05-10 6:28 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536B9654.7020509@gmail.com \
--to=ipaton0@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox