From: t.figa@samsung•com (Tomasz Figa)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V3 3/3] CLK: EXYNOS: Add clk save/restore registers for 5420
Date: Thu, 08 May 2014 19:18:18 +0200 [thread overview]
Message-ID: <536BBC5A.4030707@samsung.com> (raw)
In-Reply-To: <1399546391-30571-1-git-send-email-vikas.sajjan@samsung.com>
Hi Vikas,
Please try to more or less follow subsystem subject conventions. It
should be:
clk: samsung: exynos5420: Add clk save/restore registers
By the way, this patch only adds writes to registers that should be set
up before suspending the system and both the subject and description
should reflect this. Please be more careful when describing patches.
On 08.05.2014 12:53, Vikas Sajjan wrote:
> Adds clk save/restore registers for 5420
>
> Signed-off-by: Vikas Sajjan <vikas.sajjan@samsung•com>
> ---
> drivers/clk/samsung/clk-exynos5420.c | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/drivers/clk/samsung/clk-exynos5420.c b/drivers/clk/samsung/clk-exynos5420.c
> index 60b2681..01fd917 100644
> --- a/drivers/clk/samsung/clk-exynos5420.c
> +++ b/drivers/clk/samsung/clk-exynos5420.c
> @@ -101,6 +101,18 @@
> #define KPLL_CON0 0x28100
> #define SRC_KFC 0x28200
> #define DIV_KFC0 0x28500
> +#define SRC_MASK_CPERI 0x04300
> +#define SRC_MASK_TOP0 0x10300
> +#define SRC_MASK_TOP1 0x10304
> +#define SRC_MASK_TOP2 0x10308
> +#define SRC_MASK_TOP7 0x1031C
> +#define SRC_MASK_MAU 0x10334
> +#define SRC_MASK_FSYS 0x10340
> +#define SRC_MASK_PERIC0 0x10350
> +#define SRC_MASK_PERIC1 0x10354
> +#define SRC_MASK_ISP 0x10370
> +#define GATE_BUS_DISP1 0x10728
> +#define GATE_IP_PERIC 0x10950
Please sort the definitions according to addresses.
Best regards,
Tomasz
prev parent reply other threads:[~2014-05-08 17:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 10:53 [PATCH V3 3/3] CLK: EXYNOS: Add clk save/restore registers for 5420 Vikas Sajjan
2014-05-08 17:18 ` Tomasz Figa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536BBC5A.4030707@samsung.com \
--to=t.figa@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox