From: emilio@elopez•com.ar (Emilio López)
To: linux-arm-kernel@lists•infradead.org
Subject: [linux-sunxi] [PATCH 3/6] clk: sunxi: Move the GMAC clock to a file of its own
Date: Mon, 12 May 2014 16:45:08 -0300 [thread overview]
Message-ID: <537124C4.5080303@elopez.com.ar> (raw)
In-Reply-To: <20140512193646.GE17154@lukather>
Hi,
El 12/05/14 16:36, Maxime Ripard escribi?:
> On Sat, May 10, 2014 at 02:07:07PM -0300, Emilio L?pez wrote:
>>> +
>>> + clk = clk_register_composite(NULL, clk_name,
>>> + parents, SUN7I_A20_GMAC_PARENTS,
>>> + &mux->hw, &clk_mux_ops,
>>> + NULL, NULL,
>>> + &gate->hw, &clk_gate_ops,
>>> + 0);
>>> +
>>> + if (IS_ERR(clk))
>>> + goto iounmap_reg;
>>> +
>>> + of_clk_add_provider(node, of_clk_src_simple_get, clk);
>>> + clk_register_clkdev(clk, clk_name, NULL);
>>
>> As I mentioned on the other email, I don't think we are using
>> clkdev. Maybe we can drop it.
>
> No we aren't, but we should not really modify code while moving it. I
> can send another patch to do so, but that should not prevent this code
> from going in.
That would be great :) The patches themselves are okay, I just thought
I'd mention it so it's not forgotten.
Cheers,
Emilio
next prev parent reply other threads:[~2014-05-12 19:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-10 3:33 [PATCH 0/6] sunxi: clk: Various cleanup and rework Maxime Ripard
2014-05-10 3:33 ` [PATCH 1/6] clk: sunxi: Remove calls to clk_put Maxime Ripard
2014-05-10 3:33 ` [PATCH 2/6] clk: sunxi: Move the 24M oscillator to a file of its own Maxime Ripard
2014-05-10 16:13 ` Emilio López
2014-05-10 16:46 ` Emilio López
2014-05-11 4:35 ` Maxime Ripard
2014-05-11 4:44 ` Emilio López
2014-05-10 3:33 ` [PATCH 3/6] clk: sunxi: Move the GMAC clock " Maxime Ripard
2014-05-10 17:07 ` [linux-sunxi] " Emilio López
2014-05-12 19:36 ` Maxime Ripard
2014-05-12 19:45 ` Emilio López [this message]
2014-05-12 20:54 ` Maxime Ripard
2014-05-10 3:33 ` [PATCH 4/6] clk: sunxi: Rework clock protection code Maxime Ripard
2014-05-10 3:33 ` [PATCH 5/6] clk: sun6i: Protect CPU clock Maxime Ripard
2014-05-10 3:33 ` [PATCH 6/6] clk: sun6i: Protect SDRAM gating bit Maxime Ripard
2014-05-10 17:22 ` [linux-sunxi] [PATCH 0/6] sunxi: clk: Various cleanup and rework Emilio López
2014-05-13 1:12 ` Mike Turquette
2014-05-15 15:10 ` Emilio López
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537124C4.5080303@elopez.com.ar \
--to=emilio@elopez$(echo .)com.ar \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox