From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/2] ARM: tegra: initial add of Colibri T30
Date: Tue, 13 May 2014 13:49:12 -0600 [thread overview]
Message-ID: <53727738.4080901@wwwdotorg.org> (raw)
In-Reply-To: <d45ec5351ce8ef03256061bdc4b0ba673bd40c66.1400001937.git.stefan@agner.ch>
On 05/13/2014 11:27 AM, stefan at agner.ch wrote:
> This patch adds the device tree to support Toradex Colibri T30, a
> computer on module which can be used on different carrier boards.
>
> The module consists of a Tegra 30 SoC, two PMIC, DDR3L RAM, eMMC,
> a LM95245 temperature sensor and an AX88772B USB Ethernet
> Controller. Furthermore, there is a STMPE811 and SGTL5000 audio
> codec which are not yet supported. Anything that is not self
> contained on the module is disabled by default.
>
> The device tree for the Evaluation Board includes the modules
> device tree and enables the supported pheripherials of the carrier
> board (the Evaluation Board supports almost all of them).
> diff --git a/arch/arm/boot/dts/tegra30-colibri-eval-v3.dts b/arch/arm/boot/dts/tegra30-colibri-eval-v3.dts
> +#include "tegra30-colibri.dtsi"
> +
> +/ {
> + model = "Toradex Colibri T30 on Colibri Evaluation Board";
> + compatible = "toradex,colibri_t30-eval-v3", "nvidia,tegra30";
That should include all the compatible values "inherited" from the
Colibri T30 module .dtsi file too.
> + aliases {
> + rtc0 = "/i2c at 7000c000/rtc at 68";
> + rtc1 = "/i2c at 7000d000/tps65911 at 2d";
> + rtc2 = "/rtc at 7000e000";
> + };
Wow, no shortage of RTCs!
> + /* SPI1: Colibri SSP */
> + spi at 7000d400 {
> + status = "okay";
> + spi-max-frequency = <25000000>;
> + can0: can at 0 {
> + compatible = "microchip,mcp2515";
> + reg = <0>;
> + clocks = <&clk16m>;
> + interrupt-parent = <&gpio>;
> + interrupts = <TEGRA_GPIO(S, 0) GPIO_ACTIVE_LOW>;
> + spi-max-frequency = <10000000>;
So this chip doesn't get confused by a faster clock frequency when its
chip-select line isn't asserted? I would have expected spi-max-frequency
for the bus to be the minimum value that any device on the bus would
tolerate.
> + /* EHCI instance 0: USB1_DP/N -> USBC_P/N */
> + usb at 7d000000 {
> + status = "okay";
> + dr_mode = "otg";
The dr_mode property is only for the PHY node.
> + panel: panel {
> + compatible = "edt,et057090dhu", "simple-panel";
The panel-simple driver doesn't seem to know about that EDT panel. How
will it work out the display timings?
> diff --git a/arch/arm/boot/dts/tegra30-colibri.dtsi b/arch/arm/boot/dts/tegra30-colibri.dtsi
> +/ {
> + model = "Toradex Colibri T30";
> + compatible = "toradex,colibri_t30-v11b",
> + "toradex,colibri_t30-v11c",
> + "toradex,colibri_t30-v11d",
> + "toradex,colibri_t30", "nvidia,tegra30";
Do we really need all those compatible values? If those board revisions
are all SW-compatible, then you may as well write just:
compatible = "toradex,colibri_t30", "nvidia,tegra30";
> + aliases {
> + serial0 = &uarta;
> + serial1 = &uartd;
> + serial2 = &uartb;
> + };
tegra20.dtsi already sets the alias names for the serial ports. Previous
discussions settled on giving each on-chip UART a static name, rather
than renaming them per board.
> + pmc at 7000e400 {
> + status = "okay";
The PMC node isn't disabled in tegra20.dtsi, so you don't need the
status property here.
next prev parent reply other threads:[~2014-05-13 19:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 17:27 [PATCH 0/2] ARM: tegra: initial support for Colibri T30 stefan at agner.ch
2014-05-13 17:27 ` [PATCH 1/2] ARM: tegra: enable MCP251x CAN controller and DS1307 RTC stefan at agner.ch
2014-05-13 19:57 ` Stephen Warren
2014-05-13 17:27 ` [PATCH 2/2] ARM: tegra: initial add of Colibri T30 stefan at agner.ch
2014-05-13 19:49 ` Stephen Warren [this message]
2014-05-14 7:22 ` Marcel Ziswiler
2014-05-14 14:32 ` Thierry Reding
2014-05-14 15:38 ` Stephen Warren
[not found] <107aeb48982529858267cb85c792b35e@agner.ch>
2014-05-15 18:13 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53727738.4080901@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox