From: boris.brezillon@free-electrons•com (Boris BREZILLON)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 5/7] clk: sunxi: add PRCM (Power/Reset/Clock Management) clks support
Date: Wed, 14 May 2014 09:30:59 +0200 [thread overview]
Message-ID: <53731BB3.4060504@free-electrons.com> (raw)
In-Reply-To: <20140514005119.16152.19787@quantum>
Hello Mike,
On 14/05/2014 02:51, Mike Turquette wrote:
> Quoting Boris BREZILLON (2014-05-09 04:11:49)
>> +struct clk_ops ar100_ops = {
>> + .recalc_rate = ar100_recalc_rate,
>> + .determine_rate = ar100_determine_rate,
>> + .set_parent = ar100_set_parent,
>> + .get_parent = ar100_get_parent,
>> + .set_rate = ar100_set_rate,
>> +};
> I might be having a brain fart, but is there a valid case for having
> both a .recalc_rate and a .determine_rate? I believe that the former
> will never be used and the latter will always be used by the clock
> framework core.
I think you're mistaking recalc_rate for round_rate.
AFAIK, recalc_rate is mandatory for a clk that implement either
round_rate or determine_rate.
Best Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-05-14 7:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 11:11 [PATCH v3 0/7] mfd: add basic sun6i A31 PRCM support Boris BREZILLON
2014-05-09 11:11 ` [PATCH v3 1/7] reset: sunxi: document sunxi's reset controllers bindings Boris BREZILLON
2014-05-09 11:11 ` [PATCH v3 2/7] reset: sunxi: allow MFD subdevices probe Boris BREZILLON
2014-05-09 11:11 ` [PATCH v3 3/7] mfd: add support for sun6i PRCM (Power/Reset/Clock Management) unit Boris BREZILLON
2014-05-09 13:52 ` Lee Jones
2014-05-09 14:01 ` Boris BREZILLON
2014-05-15 15:17 ` Maxime Ripard
2014-05-19 9:21 ` Lee Jones
2014-05-19 9:27 ` Maxime Ripard
2014-05-19 13:32 ` Lee Jones
2014-05-19 14:05 ` Maxime Ripard
2014-05-19 14:24 ` Lee Jones
2014-05-19 14:29 ` Lee Jones
2014-05-09 11:11 ` [PATCH v3 4/7] mfd: sun6i-prcm: document DT bindings Boris BREZILLON
2014-05-19 14:26 ` Lee Jones
2014-05-09 11:11 ` [PATCH v3 5/7] clk: sunxi: add PRCM (Power/Reset/Clock Management) clks support Boris BREZILLON
2014-05-13 15:09 ` Emilio López
2014-05-14 0:51 ` Mike Turquette
2014-05-14 7:30 ` Boris BREZILLON [this message]
2014-05-14 22:39 ` Mike Turquette
2014-05-09 11:11 ` [PATCH v3 6/7] clk: sunxi: document PRCM clock compatible strings Boris BREZILLON
2014-05-09 11:11 ` [PATCH v3 7/7] ARM: sunxi: dt: add PRCM clk and reset controller subdevices Boris BREZILLON
2014-05-13 15:17 ` Emilio López
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53731BB3.4060504@free-electrons.com \
--to=boris.brezillon@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox