From: t.figa@samsung•com (Tomasz Figa)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V5 18/20] ARM: exynos: cpuidle: Pass the AFTR callback to the platform_data
Date: Thu, 15 May 2014 16:07:48 +0200 [thread overview]
Message-ID: <5374CA34.1030405@samsung.com> (raw)
In-Reply-To: <5370E648.10006@linaro.org>
Arnd, Kukjin, Daniel,
On 12.05.2014 17:18, Daniel Lezcano wrote:
> On 05/09/2014 02:02 PM, Tomasz Figa wrote:
>> Hi Arnd,
>>
>> On 09.05.2014 12:56, Arnd Bergmann wrote:
>>> On Friday 11 April 2014, Daniel Lezcano wrote:
>>>> No more dependency on the arch code. The platform_data field is used to set the
>>>> PM callback as the other cpuidle drivers.
>>>>
>>>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro•org>
>>>> Reviewed-by: Viresh Kumar <viresh.kumar@linaro•org>
>>>> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung•com>
>>>
>>> This has just shown up in linux-next and broken randconfig builds.
>>>
>>>> diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
>>>> index fe8dac8..d22f0e4 100644
>>>> --- a/arch/arm/mach-exynos/exynos.c
>>>> +++ b/arch/arm/mach-exynos/exynos.c
>>>> @@ -221,8 +221,9 @@ void exynos_restart(enum reboot_mode mode, const char *cmd)
>>>> }
>>>>
>>>> static struct platform_device exynos_cpuidle = {
>>>> - .name = "exynos_cpuidle",
>>>> - .id = -1,
>>>> + .name = "exynos_cpuidle",
>>>> + .dev.platform_data = exynos_enter_aftr,
>>>> + .id = -1,
>>>> };
>>>>
>>>
>>> This is wrong on many levels, can we please do this properly?
>>>
>>> * The exynos_enter_aftr function is compiled conditionally, so you can't just
>>> reference it from generic code, or you get a link error.
>>
>> +1
>
> That is true but still we have a link error without this patch. We
> shouldn't register and declare this structure if CONFIG_PM /
> CONFIG_CPU_IDLE are not set.
>
>>> * 'static struct platform_device ...' has been deprecated for at least a decade,
>>> stop doing that. For any platform devices that get registered, there is
>>> platform_device_register_simple().
>>
>> +0.5
>>
>> The missing 0.5 is because you can't pass platform data using
>> platform_device_register_simple(). There is
>> platform_device_register_resndata(), though.
>>
>>> * There shouldn't need to be a platform_device to start with, this should all
>>> come from DT. We can't do this on arm64 anyway, so any code that may be
>>> shared between arm32 and arm64 should have proper abstractions.
>>
>> -1
>>
>> Exynos cpuidle is not a device on the SoC, so I don't think there is any
>> way to represent it in DT. The only thing I could see this is matching
>> root node with a central SoC driver that instantiates specific
>> subdevices, such as cpufreq and cpuidle, but I don't see any available
>> infrastructure for this.
>
> There is a RFC for defining generic idle states [1].
>
> The idea behind using the platform driver framework is to unify the code
> across the different drivers and separate the PM / cpuidle code.
>
> By this way, we can move the different drivers to drivers/cpuidle and
> store them in a single place. That make easier the tracking, the review
> and the maintenance.
>
> I am ok to by using platform_device_register_resndata() but I would
> prefer to do that a bit later by converting the other drivers too. That
> will be easier if we have them grouped in a single directory (this is
> what does this patchset at the end).
>
> As there are some more work based on this patchset and the link error
> could be fixed as an independent patch, I would recommend to
> re-integrate it in the tree as asked by Bartlomiej.
In general, it would be nice to have everything done properly, but I'd
consider Daniel's series as a huge improvement already and a nice
intermediate step towards further clean-up.
So based on the comments quoted above, instead of stalling the
development, I'd suggest to accept this series and then move forward.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-05-15 14:07 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 10:39 [PATCH V5 00/20] ARM: exynos: cpuidle: Move the driver to drivers/cpuidle Daniel Lezcano
2014-04-11 10:39 ` [PATCH V5 01/20] ARM: EXYNOS: Move arm core power down clock to exynos5250 common clock Daniel Lezcano
2014-04-11 10:39 ` [PATCH V5 02/20] ARM: exynos: cpuidle: Prevent forward declaration Daniel Lezcano
2014-04-11 10:39 ` [PATCH V5 03/20] ARM: exynos: cpuidle: Use cpuidle_register Daniel Lezcano
2014-04-11 10:39 ` [PATCH V5 04/20] ARM: exynos: cpuidle: Change function name prefix Daniel Lezcano
2014-04-11 10:40 ` [PATCH V5 05/20] ARM: exynos: cpuidle: Encapsulate register access inside a function Daniel Lezcano
2014-04-11 10:40 ` [PATCH V5 06/20] ARM: exynos: cpuidle: Move some code inside the idle_finisher Daniel Lezcano
2014-04-11 10:40 ` [PATCH V5 07/20] ARM: exynos: cpuidle: Fix S5P_WAKEUP_STAT call Daniel Lezcano
2014-04-11 10:40 ` [PATCH V5 08/20] ARM: exynos: cpuidle: Use the cpu_pm notifier Daniel Lezcano
2014-04-11 10:40 ` [PATCH V5 09/20] ARM: exynos: cpuidle: Move scu_enable in " Daniel Lezcano
2014-04-11 10:40 ` [PATCH V5 10/20] ARM: exynos: cpuidle: Remove ifdef for scu_enable Daniel Lezcano
2014-04-11 10:40 ` [PATCH V5 11/20] ARM: exynos: cpuidle: Pass wakeup mask parameter to function Daniel Lezcano
2014-04-11 10:40 ` [PATCH V5 12/20] ARM: exynos: cpuidle: Encapsulate boot vector code into a function Daniel Lezcano
2014-04-11 10:40 ` [PATCH V5 13/20] ARM: exynos: cpuidle: Disable cpuidle for 5440 Daniel Lezcano
2014-04-11 10:40 ` [PATCH V5 14/20] ARM: exynos: cpuidle: Encapsulate the AFTR code into a function Daniel Lezcano
2014-04-11 10:40 ` [PATCH V5 15/20] ARM: exynos: cpuidle: Move the AFTR state function into pm.c Daniel Lezcano
2014-04-11 10:40 ` [PATCH V5 16/20] ARM: exynos: cpuidle: Move the power sequence call in the cpu_pm notifier Daniel Lezcano
2014-06-26 9:07 ` Chander Kashyap
2014-06-26 9:48 ` Tomasz Figa
2014-06-27 5:56 ` Chander Kashyap
2014-04-11 10:40 ` [PATCH V5 17/20] ARM: exynos: cpuidle: Move S5P_CHECK_SLEEP into pm.c Daniel Lezcano
2014-04-11 10:40 ` [PATCH V5 18/20] ARM: exynos: cpuidle: Pass the AFTR callback to the platform_data Daniel Lezcano
2014-05-09 10:56 ` Arnd Bergmann
2014-05-09 12:02 ` Tomasz Figa
2014-05-09 15:29 ` Bartlomiej Zolnierkiewicz
2014-05-12 15:18 ` Daniel Lezcano
2014-05-15 14:07 ` Tomasz Figa [this message]
2014-05-15 20:40 ` Kukjin Kim
2014-05-21 7:15 ` Daniel Lezcano
2014-05-21 8:10 ` Arnd Bergmann
2014-05-21 9:02 ` Daniel Lezcano
2014-05-21 14:56 ` Arnd Bergmann
2014-05-21 13:54 ` Kukjin Kim
2014-05-09 13:10 ` Kukjin Kim
2014-04-11 10:40 ` [PATCH V5 19/20] ARM: exynos: cpuidle: Cleanup all unneeded headers from cpuidle.c Daniel Lezcano
2014-04-11 10:40 ` [PATCH V5 20/20] ARM: exynos: cpuidle: Move the driver to drivers/cpuidle directory Daniel Lezcano
2014-04-14 9:01 ` [PATCH V5 00/20] ARM: exynos: cpuidle: Move the driver to drivers/cpuidle Daniel Lezcano
2014-04-24 17:02 ` Tomasz Figa
2014-04-26 11:05 ` Kukjin Kim
2014-05-22 18:35 ` Kukjin Kim
2014-05-22 18:57 ` Daniel Lezcano
2014-05-23 15:32 ` Daniel Lezcano
2014-05-23 21:31 ` Tomasz Figa
2014-05-24 4:57 ` Sachin Kamat
2014-05-24 17:24 ` [PATCH] ARM: exynos: Fix kernel panic when unplugging CPU1 on 4210 Daniel Lezcano
2014-05-24 17:31 ` Daniel Lezcano
2014-05-25 19:51 ` Kukjin Kim
2014-05-24 17:32 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5374CA34.1030405@samsung.com \
--to=t.figa@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox