From: kishon@ti•com (Kishon Vijay Abraham I)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 4/4] phy: miphy365x: Provide support for the MiPHY356x Generic PHY
Date: Mon, 19 May 2014 19:51:08 +0530 [thread overview]
Message-ID: <537A1354.6010408@ti.com> (raw)
In-Reply-To: <20140305075548.GG20016@e106331-lin.cambridge.arm.com>
Hi,
On Wednesday 05 March 2014 01:25 PM, Mark Rutland wrote:
> On Fri, Feb 14, 2014 at 11:23:56AM +0000, Lee Jones wrote:
>> The MiPHY365x is a Generic PHY which can serve various SATA or PCIe
>> devices. It has 2 ports which it can use for either; both SATA, both
>> PCIe or one of each in any configuration.
>>
>> Cc: Kishon Vijay Abraham I <kishon@ti•com>
>> Signed-off-by: Lee Jones <lee.jones@linaro•org>
>> ---
>> drivers/phy/Kconfig | 10 +
>> drivers/phy/Makefile | 1 +
>> drivers/phy/phy-miphy365x.c | 614 ++++++++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 625 insertions(+)
>> create mode 100644 drivers/phy/phy-miphy365x.c
>
> [...]
>
>> +enum miphy_sata_gen {
>> + SATA_GEN1 = 1,
>> + SATA_GEN2,
>> + SATA_GEN3
>> +};
>
> It would be nice to have a comment here that these values are ABI and
> cannot change.
>
> [...]
>
>> +static struct phy *miphy365x_phy_xlate(struct device *dev,
>> + struct of_phandle_args *args)
>> +{
>> + struct miphy365x_dev *state = dev_get_drvdata(dev);
>> + u8 port = args->args[0];
>> + u8 type = args->args[1];
>
> In case of a bad dt, it would be nice to check args->arg_count == 2.
>
> ALso, we throw away the top 24 bits, which may have been set
> erroneously. If we want to make use of those in future we should test
> they are clear here to force people to do the right thing.
I don't seem to have the update patch series? Can you resend please?
Thanks
Kishon
>
> Otherwise, this looks fine to me.
>
> With those additions:
>
> Acked-by: Mark Rutland <mark.rutland@arm•com>
>
> Cheers,
> Mark.
>
next prev parent reply other threads:[~2014-05-19 14:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 11:23 [PATCH 1/4] phy: miphy365x: Add Device Tree bindings for the MiPHY365x Lee Jones
2014-02-14 11:23 ` [PATCH 2/4] phy: miphy365x: Add MiPHY365x header file for DT x Driver defines Lee Jones
2014-03-05 7:35 ` Mark Rutland
2014-02-14 11:23 ` [PATCH 3/4] ARM: DT: STi: Add DT node for MiPHY365x Lee Jones
2014-03-01 18:43 ` Kishon Vijay Abraham I
2014-03-05 7:42 ` Mark Rutland
2014-02-14 11:23 ` [PATCH 4/4] phy: miphy365x: Provide support for the MiPHY356x Generic PHY Lee Jones
2014-02-25 10:51 ` Lee Jones
2014-03-05 7:55 ` Mark Rutland
2014-05-19 14:21 ` Kishon Vijay Abraham I [this message]
2014-05-19 16:41 ` Lee Jones
2014-03-05 7:34 ` [PATCH 1/4] phy: miphy365x: Add Device Tree bindings for the MiPHY365x Mark Rutland
2014-03-05 8:40 ` Lee Jones
2014-03-05 9:12 ` Lee Jones
2014-03-10 16:22 ` [PATCH v2 " Lee Jones
2014-03-12 11:13 ` Mark Rutland
-- strict thread matches above, loose matches on Subject: below --
2014-05-22 13:53 [RESEND 0/4] phy: Introduce support for MiPHY365x Lee Jones
2014-05-22 13:53 ` [PATCH 4/4] phy: miphy365x: Provide support for the MiPHY356x Generic PHY Lee Jones
2014-04-29 7:21 [PATCH 0/4] phy: Introduce support for MiPHY365x Lee Jones
2014-04-29 7:21 ` [PATCH 4/4] phy: miphy365x: Provide support for the MiPHY356x Generic PHY Lee Jones
2014-03-12 13:14 [PATCH 0/4] phy: Introduce support for MiPHY365x Lee Jones
2014-03-12 13:14 ` [PATCH 4/4] phy: miphy365x: Provide support for the MiPHY356x Generic PHY Lee Jones
2014-02-12 16:03 [PATCH 1/4] phy: miphy365x: Add Device Tree bindings for the MiPHY365x Lee Jones
2014-02-12 16:03 ` [PATCH 4/4] phy: miphy365x: Provide support for the MiPHY356x Generic PHY Lee Jones
2014-02-12 16:54 ` Mark Rutland
2014-02-13 10:47 ` Lee Jones
2014-02-13 6:53 ` Kishon Vijay Abraham I
2014-02-13 10:29 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537A1354.6010408@ti.com \
--to=kishon@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox