From: zhangfei.gao@linaro•org (zhangfei)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/3] Documentation: add Device tree bindings for Hisilicon hix5hd2 ethernet
Date: Tue, 20 May 2014 10:12:23 +0800 [thread overview]
Message-ID: <537ABA07.7020308@linaro.org> (raw)
In-Reply-To: <537A30AA.8080107@cogentembedded.com>
On 05/20/2014 12:26 AM, Sergei Shtylyov wrote:
> On 05/19/2014 04:57 PM, Zhangfei Gao wrote:
>> +Hisilicon hix5hd2 Ethernet Controller
>> +
>> +Required properties:
>> +- compatible: should be "hisilicon,hix5hd2-mac".
>> +- reg : Specifies base physical address(s) and size of the device
>> registers.
>
> Er, I must note that the colon style here is not consistent with the
> rest of the properties, i.e. there's space before the colon here, while
> in other cases there's none.
Will remove the space.
>
>> + The first region is the mac register base and size.
>
> s/mac/MAC/.
>
>> + The second region is external interface control register.
>> +- interrupts: Should contain the MAC interrupts
>> +- #address-cells: Must be <1>.
>> +- #size-cells: Must be <0>.
>
> Descriptions should consistently start with a lower case, I think...
OK.
>
>> +- phy-mode: see ethernet.txt [1].
>> +- phy-handle: see ethernet.txt [1].
>> +- mac-address: see ethernet.txt [1].
>> +- clocks: clock phandle and specifier pair.
>> +
>> +- phy subnode: inherits from phy binding [2]
>
> s/phy/PHY/.
>
>> +
>> +[1] Documentation/devicetree/bindings/net/ethernet.txt
>> +[2] Documentation/devicetree/bindings/net/phy.txt
>> +
>> +Example:
>> + gmac0: ethernet at f9840000 {
>> + compatible = "hisilicon,hix5hd2-mac";
>> + reg = <0xf9840000 0x1000>,<0xf984300c 0x4>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + phy-handle = <&phy0>;
>> + phy-mode = "mii";
>> + mac-address = [00 00 00 00 00 00];
>
> Don't think that's a good value, unless this is only a placeholder.
Yes, mac-address is placeholder here and would be filled by boot-loader.
Otherwise random mac addr will be used.
>
>> + interrupts = <0 71 4>;
>> + clocks = <&clock HIX5HD2_MAC0_CLK>;
>> +
>> + phy0: ethernet-phy at 2 {
>
> I'd rather label ut phy2...
OK
>
>> + reg = <2>;
>> + compatible = "ethernet-phy-ieee802.3-c22";
>
> This is the default "compatible", i.e. there's no need to specify
> it, IIRC.
Got it, find it is clarified in phy.txt.
Thanks
next prev parent reply other threads:[~2014-05-20 2:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 12:57 [PATCH 0/3] add hix5hd2 mac driver Zhangfei Gao
2014-05-19 12:57 ` [PATCH 1/3] hix5hd2-clock: add complex clk Zhangfei Gao
2014-05-19 13:11 ` David Laight
2014-05-20 12:02 ` zhangfei
2014-05-19 12:57 ` [PATCH 2/3] Documentation: add Device tree bindings for Hisilicon hix5hd2 ethernet Zhangfei Gao
2014-05-19 16:26 ` Sergei Shtylyov
2014-05-20 2:12 ` zhangfei [this message]
2014-05-19 12:57 ` [PATCH 3/3] net: hisilicon: add hix5hd2 mac driver Zhangfei Gao
2014-05-25 12:25 ` zhangfei
2014-05-26 14:51 ` Arnd Bergmann
2014-05-27 3:57 ` zhangfei
2014-05-27 13:25 ` Arnd Bergmann
2014-05-28 5:17 ` zhangfei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537ABA07.7020308@linaro.org \
--to=zhangfei.gao@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox