From: maxime.coquelin@st•com (Maxime Coquelin)
To: linux-arm-kernel@lists•infradead.org
Subject: [STLinux Kernel] [PATCH 3/4] ARM: DT: STi: Add DT node for MiPHY365x
Date: Tue, 20 May 2014 09:19:05 +0200 [thread overview]
Message-ID: <537B01E9.8020507@st.com> (raw)
In-Reply-To: <20140519155106.GR4978@lee--X1>
On 05/19/2014 05:51 PM, Lee Jones wrote:
>>> The MiPHY365x is a Generic PHY which can serve various SATA or PCIe
>>> devices. It has 2 ports which it can use for either; both SATA, both
>>> PCIe or one of each in any configuration.
>>>
>>> Cc: Srinivas Kandagatla <srinivas.kandagatla@st•com>
>>> Acked-by: Mark Rutland <mark.rutland@arm•com>
>>> Acked-by: Alexandre Torgue <alexandre.torgue@st•com>
>>> Signed-off-by: Lee Jones <lee.jones@linaro•org>
>>> ---
>>> arch/arm/boot/dts/stih416-b2020-revE.dts | 22 ++++++++++++++++++++++
>>> arch/arm/boot/dts/stih416-b2020.dts | 6 ++++++
>>> arch/arm/boot/dts/stih416.dtsi | 14 ++++++++++++++
>>> 3 files changed, 42 insertions(+)
>>> create mode 100644 arch/arm/boot/dts/stih416-b2020-revE.dts
>>>
>>> diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts b/arch/arm/boot/dts/stih416-b2020-revE.dts
>>> new file mode 100644
>>> index 0000000..23fdaf7
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/stih416-b2020-revE.dts
>>> @@ -0,0 +1,22 @@
>>> +/*
>>> + * Copyright (C) 2014 STMicroelectronics Limited.
>>> + * Author: Lee Jones <lee.jones@linaro•org>
>>> + *
>>> + * This program is free software; you can redistribute it and/or modify
>>> + * it under the terms of the GNU General Public License version 2 as
>>> + * publishhed by the Free Software Foundation.
>>> + */
>>> +/dts-v1/;
>>> +#include "stih416.dtsi"
>>> +#include "stih41x-b2020.dtsi"
>>> +/ {
>>> + model = "STiH416 B2020 REV-E";
>>> + compatible = "st,stih416-b2020", "st,stih416";
>>> +
>>> + soc {
>>> + miphy365x_phy: miphy365x at fe382000 {
>>> + st,pcie-tx-pol-inv;
>>> + st,sata-gen = <3>;
>>> + };
>>> + };
>>> +};
>> Shouldn't this new board being added in a separate patch?
>
> I certainly can do that, but I don't think that it's necessary?
I think it is, as you introduce a new board.
Moreover, the miphy description being the same as in stih416-b2020.dts,
so I don't understand why you introduce this board for this feature.
>
>>> diff --git a/arch/arm/boot/dts/stih416-b2020.dts b/arch/arm/boot/dts/stih416-b2020.dts
>>> index 276f28d..172f222 100644
>>> --- a/arch/arm/boot/dts/stih416-b2020.dts
>>> +++ b/arch/arm/boot/dts/stih416-b2020.dts
>>> @@ -13,4 +13,10 @@
>>> model = "STiH416 B2020";
>>> compatible = "st,stih416", "st,stih416-b2020";
>>>
>>> + soc {
>>> + miphy365x_phy: miphy365x at fe382000 {
>>> + st,pcie-tx-pol-inv;
>>> + st,sata-gen = <3>;
>>> + };
>>> + };
>>> };
>> ...
>
next prev parent reply other threads:[~2014-05-20 7:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 7:21 [PATCH 0/4] phy: Introduce support for MiPHY365x Lee Jones
2014-04-29 7:21 ` [PATCH 1/4] phy: miphy365x: Add Device Tree bindings for the MiPHY365x Lee Jones
2014-05-19 13:56 ` Lee Jones
2014-05-19 14:00 ` Kishon Vijay Abraham I
2014-05-19 14:07 ` Lee Jones
2014-04-29 7:21 ` [PATCH 2/4] phy: miphy365x: Add MiPHY365x header file for DT x Driver defines Lee Jones
2014-04-29 7:21 ` [PATCH 3/4] ARM: DT: STi: Add DT node for MiPHY365x Lee Jones
2014-05-19 15:42 ` [STLinux Kernel] " Maxime Coquelin
2014-05-19 15:51 ` Lee Jones
2014-05-20 7:19 ` Maxime Coquelin [this message]
2014-05-20 8:28 ` Lee Jones
2014-05-20 8:41 ` Maxime Coquelin
2014-04-29 7:21 ` [PATCH 4/4] phy: miphy365x: Provide support for the MiPHY356x Generic PHY Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537B01E9.8020507@st.com \
--to=maxime.coquelin@st$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox