From: ivan.khoronzhuk@ti•com (Ivan Khoronzhuk)
To: linux-arm-kernel@lists•infradead.org
Subject: [Patch v3 0/5] Introduce keystone reset driver
Date: Wed, 21 May 2014 17:28:43 +0300 [thread overview]
Message-ID: <537CB81B.4020205@ti.com> (raw)
In-Reply-To: <10992709.10WgsOixXr@wuerfel>
On 05/20/2014 10:27 PM, Arnd Bergmann wrote:
> On Tuesday 20 May 2014 21:35:23 Ivan Khoronzhuk wrote:
>> Thank for the note.
>>
>> Ok.
>>
>> Memory map:
>> [00 02310000 - 00 023101FF] size=512 PLL Controller
>> [00 02620000 - 00 02620FFF] size=4K device state control registers
>>
>> I'll define in DT two new syscon compatible nodes like:
>>
>> pllctrl: pll_controller {
>> compatible = "syscon";
>> reg = <0x2310000 0x200>;
>> };
>>
>> devctrl: device_state_control {
>> compatible = "syscon";
>> reg = <0x2620000 0x1000>;
>> };
> Please add a well-defined compatible-string in addition to "syscon" as
> well.
>
>> then correct reset-controller node like:
>>
>> rstctrl: reset-controller {
>> compatible = "ti,keystone-reset";
>> reg = <0xE4 0x10>, <0x328 0x10>;
>> reg-names = "pllregs", "muxregs";
>> syscon1 = <&pllctrl>;
>> syscon2 = <&devctrl>;
>> ti,wdt_list = <0>;
>> };
> You can't really use the "reg" property to refer to syscon
> registers, but you can make up your own property for that,
> or put the register numbers into the syscon1/2 properties,
> or just hardcode the offsets in the driver.
>
>> And correct reset-controller code to get regmap by phandle,
>> then access registers by regmap.
>>
>> Also I'll post two separate patches that add syscon nodes in question.
> Sounds good, thanks!
>
> Arnd
Arnd,
I've sent an updated patch series v4 with your notes applied.
Could you please take a glance on it.
--
Regards,
Ivan Khoronzhuk
prev parent reply other threads:[~2014-05-21 14:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 10:25 [Patch v3 0/5] Introduce keystone reset driver Ivan Khoronzhuk
2014-05-19 10:25 ` [Patch v3 1/5] Power: reset: keystone-reset: introduce " Ivan Khoronzhuk
2014-05-19 10:25 ` [Patch v3 2/5] Power: reset: add bindings for " Ivan Khoronzhuk
2014-05-19 10:25 ` [Patch v3 3/5] ARM: keystone: remove redundant reset stuff Ivan Khoronzhuk
2014-05-19 10:25 ` [Patch v3 4/5] ARM: dts: keystone: update reset node to work with reset driver Ivan Khoronzhuk
2014-05-19 10:25 ` [Patch v3 5/5] ARM: keystone: enable reset driver support Ivan Khoronzhuk
2014-05-19 15:07 ` [Patch v3 0/5] Introduce keystone reset driver Santosh Shilimkar
2014-05-19 17:47 ` Arnd Bergmann
2014-05-20 13:16 ` Ivan Khoronzhuk
2014-05-20 13:44 ` Arnd Bergmann
2014-05-20 13:49 ` Santosh Shilimkar
2014-05-20 18:35 ` Ivan Khoronzhuk
2014-05-20 19:27 ` Arnd Bergmann
2014-05-21 14:28 ` Ivan Khoronzhuk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537CB81B.4020205@ti.com \
--to=ivan.khoronzhuk@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox