From: gregory.clement@free-electrons•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: mvebu: mark armada_370_xp_pmsu_idle_prepare() as static
Date: Mon, 26 May 2014 17:05:11 +0200 [thread overview]
Message-ID: <53835827.80101@free-electrons.com> (raw)
In-Reply-To: <1401116474-31221-1-git-send-email-thomas.petazzoni@free-electrons.com>
On 26/05/2014 17:01, Thomas Petazzoni wrote:
> The armada_370_xp_pmsu_idle_prepare() function is only used internally
> to pmsu.c, so there's no reason to not use the static qualifier.
Indeed, it was exported in the 1st version of the series, and then I forgot
to make it static later.
Acked-by: Gregory CLEMENT <gregory.clement@free-electrons•com>
Thanks,
Gregory
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons•com>
> ---
> arch/arm/mach-mvebu/pmsu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-mvebu/pmsu.c b/arch/arm/mach-mvebu/pmsu.c
> index 53a55c8..6e83d32 100644
> --- a/arch/arm/mach-mvebu/pmsu.c
> +++ b/arch/arm/mach-mvebu/pmsu.c
> @@ -148,7 +148,7 @@ static void armada_370_xp_cpu_resume(void)
> }
>
> /* No locking is needed because we only access per-CPU registers */
> -void armada_370_xp_pmsu_idle_prepare(bool deepidle)
> +static void armada_370_xp_pmsu_idle_prepare(bool deepidle)
> {
> unsigned int hw_cpu = cpu_logical_map(smp_processor_id());
> u32 reg;
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2014-05-26 15:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 15:01 [PATCH] ARM: mvebu: mark armada_370_xp_pmsu_idle_prepare() as static Thomas Petazzoni
2014-05-26 15:05 ` Gregory CLEMENT [this message]
2014-06-20 20:44 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53835827.80101@free-electrons.com \
--to=gregory.clement@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox