From: gdjakov@mm-sol•com (Georgi Djakov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 4/4] ARM: debug: qcom: add UART addresses to Kconfig help
Date: Tue, 27 May 2014 15:05:53 +0300 [thread overview]
Message-ID: <53847FA1.60509@mm-sol.com> (raw)
In-Reply-To: <CABuKBeJXqSi=6XY5Fg7mg_daQ4D8ornS-kn7NDPktCtro7yNNw@mail.gmail.com>
On 05/26/2014 08:17 PM, Matthias Brugger wrote:
> 2014-05-26 15:45 GMT+02:00 Georgi Djakov <gdjakov@mm-sol•com>:
>> On 23.05.14, 19:39, Matthias Brugger wrote:
>>>
>>> 2014-05-23 17:12 GMT+02:00 Georgi Djakov <gdjakov@mm-sol•com>:
>>>>
>>>> Add information about the APQ8084 debug UART physical and virtual
>>>> addresses in the DEBUG_QCOM_UARTDM Kconfig help section.
>>>> Requires: https://lkml.org/lkml/2014/4/14/312
>>>>
>>>> Signed-off-by: Georgi Djakov <gdjakov@mm-sol•com>
>>>> ---
>>>> arch/arm/Kconfig.debug | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
>>>> index 40ee328..e71723d 100644
>>>> --- a/arch/arm/Kconfig.debug
>>>> +++ b/arch/arm/Kconfig.debug
>>>> @@ -376,6 +376,7 @@ choice
>>>> their output to the serial port on Qualcomm devices.
>>>>
>>>> ARCH DEBUG_UART_PHYS DEBUG_UART_BASE
>>>> + APQ8084 0xf995e000 0xfa75e000
>>>> MSM8X60 0x19c40000 0xf0040000
>>>> MSM8960 0x16440000 0xf0040000
>>>> MSM8974 0xf991e000 0xfa71e000
>>>
>>>
>>> You don't have any uart defined in your dts. You should add them
>>> before any adding low level debug support.
>>> Otherwise there might be problems in booting a multi-platform kernel.
>>>
>>
>> Thanks for the comment! As the uart depends on clocks, i am adding it to the
>> dts as part of my global clock controller patchset [1].
>> In this patch i am just adding some information to the help section.
>> Do you see any problem with this?
>
> Are the patches for the clock controller applied already?
> If not, I would consider to add this patch to clock controller series.
>
No, they are not applied yet. The uart dts definition depends on clocks, but the
DEBUG_LL support does not. And the DEBUG_LL support is already there as it is
common with other SoCs. I am sorry, but i don't see dependency between the dts
definition and this patch. Could you explain please?
Thanks,
Georgi
next prev parent reply other threads:[~2014-05-27 12:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 15:12 [PATCH v2 0/4] Add Qualcomm APQ8084 SoC support Georgi Djakov
2014-05-23 15:12 ` [PATCH v2 1/4] ARM: dts: qcom: Add " Georgi Djakov
2014-05-23 15:12 ` [PATCH v2 2/4] ARM: dts: qcom: Add APQ8084-MTP board support Georgi Djakov
2014-05-23 15:12 ` [PATCH v2 3/4] ARM: qcom: Add APQ8084 to mach-qcom Georgi Djakov
2014-05-23 15:12 ` [PATCH v2 4/4] ARM: debug: qcom: add UART addresses to Kconfig help Georgi Djakov
2014-05-23 16:39 ` Matthias Brugger
2014-05-26 13:45 ` Georgi Djakov
2014-05-26 17:17 ` Matthias Brugger
2014-05-27 12:05 ` Georgi Djakov [this message]
2014-05-29 15:26 ` Matthias Brugger
2014-05-30 7:50 ` Ivan T. Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53847FA1.60509@mm-sol.com \
--to=gdjakov@mm-sol$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox