From: vbabka@suse•cz (Vlastimil Babka)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH -mm] mm, compaction: properly signal and act upon lock and need_sched() contention - fix
Date: Mon, 02 Jun 2014 16:33:41 +0200 [thread overview]
Message-ID: <538C8B45.6070803@suse.cz> (raw)
In-Reply-To: <CAOMZO5BKaicq7NkoJO4vU5W3hiDike6kSdH+2eD=h0B5BsDjTg@mail.gmail.com>
compact_should_abort() returns true instead of false and vice versa
due to changes between v1 and v2 of the patch. This makes both async
and sync compaction abort with high probability, and has been reported
to cause e.g. soft lockups on some ARM boards, or drivers calling
dma_alloc_coherent() fail to probe with CMA enabled on different boards.
This patch fixes the return value to match comments and callers expecations.
Reported-and-tested-by: Kevin Hilman <khilman@linaro•org>
Reported-and-tested-by: Shawn Guo <shawn.guo@linaro•org>
Tested-by: Stephen Warren <swarren@nvidia•com>
Signed-off-by: Vlastimil Babka <vbabka@suse•cz>
---
mm/compaction.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/compaction.c b/mm/compaction.c
index a525cd4..5175019 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -237,13 +237,13 @@ static inline bool compact_should_abort(struct compact_control *cc)
if (need_resched()) {
if (cc->mode == MIGRATE_ASYNC) {
cc->contended = true;
- return false;
+ return true;
}
cond_resched();
}
- return true;
+ return false;
}
/* Returns true if the page is within a block suitable for migration to */
-- 1.8.4.5
next prev parent reply other threads:[~2014-06-02 14:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1399904111-23520-1-git-send-email-vbabka@suse.cz>
[not found] ` <1400233673-11477-1-git-send-email-vbabka@suse.cz>
[not found] ` <CAGa+x87-NRyK6kUiXNL_bRNEGm+DR6M3HPSLYEoq4t6Nrtnd_g@mail.gmail.com>
2014-05-23 2:48 ` [PATCH v2] mm, compaction: properly signal and act upon lock and need_sched() contention Shawn Guo
2014-05-23 8:34 ` Vlastimil Babka
2014-05-23 10:49 ` Shawn Guo
2014-05-23 15:07 ` Kevin Hilman
2014-05-30 16:59 ` Stephen Warren
2014-06-02 13:35 ` Fabio Estevam
2014-06-02 14:33 ` Vlastimil Babka [this message]
2014-06-02 15:18 ` [PATCH -mm] mm, compaction: properly signal and act upon lock and need_sched() contention - fix Fabio Estevam
2014-06-02 20:09 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538C8B45.6070803@suse.cz \
--to=vbabka@suse$(echo .)cz \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox