From: gregory.clement@free-electrons•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v6 1/6] clocksource: Add support for the Mediatek SoCs
Date: Wed, 04 Jun 2014 13:25:36 +0200 [thread overview]
Message-ID: <538F0230.7090800@free-electrons.com> (raw)
In-Reply-To: <CAL_JsqKCTZjh7o2zf_WsVi=iAR1ivTPQpvpNJ6W87jPXakMnZg@mail.gmail.com>
Hi Rob,
On 04/06/2014 13:18, Rob Herring wrote:
[...]
>> +
>> + if (of_address_to_resource(node, 0, &res))
>> + panic("Failed to parse resource\n");
>
> panics are a bit pointless at this stage since your console is
> typically not up yet. Warning and continuing on with boot gives you a
> better shot at actually seeing the message.
>
>> +
>> + if (!request_mem_region(res.start, resource_size(&res), "mtk-timer"))
>> + panic("Registers are a busy IO resource");
>> +
>> + evt->gpt_base = ioremap(res.start, resource_size(&res));
>
> of_iomap instead of these 3 calls.
Actually of_iomap doesn't request_mem_region, that's why for
mvebu we are trying now to replace of_iomap by request_mem_region/ioremap.
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2014-06-04 11:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 16:55 [PATCH v6 0/6] arm: Add basic support for Mediatek Cortex-A7 SoCs Matthias Brugger
2014-05-30 16:55 ` [PATCH v6 1/6] clocksource: Add support for the Mediatek SoCs Matthias Brugger
2014-06-04 11:18 ` Rob Herring
2014-06-04 11:25 ` Gregory CLEMENT [this message]
2014-06-04 13:46 ` Thomas Gleixner
2014-06-04 13:52 ` Rob Herring
2014-05-30 16:56 ` [PATCH v6 2/6] dt-bindings: add mtk-timer bindings Matthias Brugger
2014-06-04 11:05 ` Rob Herring
2014-05-30 16:56 ` [PATCH v6 3/6] vendor-prefixes: add prefix for Mediaktek Inc Matthias Brugger
2014-06-04 11:06 ` Rob Herring
2014-05-30 16:56 ` [PATCH v6 4/6] arm: add basic support for Mediatek MT6589 boards Matthias Brugger
2014-05-30 16:56 ` [PATCH v6 5/6] dt-bindings: add documentation for Mediatek SoC Matthias Brugger
2014-06-03 12:51 ` Rob Herring
2014-06-05 10:26 ` Matthias Brugger
2014-05-30 16:56 ` [PATCH v6 6/6] arm: mediatek: add dts for Aquaris5 mobile phone Matthias Brugger
2014-06-03 12:48 ` [PATCH v6 0/6] arm: Add basic support for Mediatek Cortex-A7 SoCs Daniel Lezcano
2014-06-03 13:15 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538F0230.7090800@free-electrons.com \
--to=gregory.clement@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox