From: boris.brezillon@free-electrons•com (Boris BREZILLON)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 3/7] drm: add Atmel HLCDC Display Controller support
Date: Sun, 15 Jun 2014 17:00:45 +0200 [thread overview]
Message-ID: <539DB51D.5080204@free-electrons.com> (raw)
In-Reply-To: <539D6839.1070703@traphandler.com>
Hello JJ,
On 15/06/2014 11:32, Jean-Jacques Hiblot wrote:
>
> On 06/09/2014 06:04 PM, Boris BREZILLON wrote:
>> The Atmel HLCDC (High LCD Controller) IP available on some Atmel SoCs (i.e.
>> at91sam9n12, at91sam9x5 family or sama5d3 family) provides a display
>> controller device.
>>
>> This display controller support at least one primary plane and might
>> provide several overlays and an hardware cursor depending on the IP
>> version.
>>
>> Signed-off-by: Boris BREZILLON <boris.brezillon@free-electrons•com>
>> ---
[...]
>> + vm.vfront_porch > 0x40 || vm.vfront_porch < 0 ||
>> + vm.vback_porch > 0x40 || vm.vback_porch < 0 ||
>> + vm.hfront_porch > 0x200 || vm.hfront_porch < 0 ||
>> + vm.hback_porch > 0x200 || vm.hback_porch < 0 ||
>> + mode->hdisplay > 2048 || mode->hdisplay < 0 ||
>> + mode->vdisplay > 2048 || mode->vdisplay < 0)
>> + return -EINVAL;
>> +
>> + regmap_write(regmap, ATMEL_HLCDC_CFG(1),
>> + (vm.hsync_len - 1) | ((vm.vsync_len - 1) << 16));
>> +
>> + regmap_write(regmap, ATMEL_HLCDC_CFG(2),
>> + (vm.vfront_porch - 1) | ((vm.vback_porch - 1) << 16));
> Acording to the datasheet, it's vm.vback_porch instead of
> (vm.vback_porch -1).
Oh, nice catch!
I'll check with Atmel that this is not a typo in their datasheet,
because all other fields need the minus 1.
Thanks for your review.
Best Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-06-15 15:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 16:04 [PATCH v2 0/7] drm: add support for Atmel HLCDC Display Controller Boris BREZILLON
2014-06-09 16:04 ` [PATCH v2 1/7] mfd: add atmel-hlcdc driver Boris BREZILLON
2014-06-15 8:53 ` Jean-Jacques Hiblot
2014-06-15 14:48 ` Boris BREZILLON
2014-06-16 7:46 ` Jean-Jacques Hiblot
2014-06-16 12:50 ` Lee Jones
2014-06-16 13:23 ` Boris BREZILLON
2014-06-16 17:03 ` Lee Jones
2014-06-16 17:09 ` Boris BREZILLON
2014-06-09 16:04 ` [PATCH v2 2/7] pwm: add support for atmel-hlcdc-pwm device Boris BREZILLON
2014-06-13 11:43 ` Alexandre Belloni
2014-06-13 12:17 ` Boris BREZILLON
2014-06-15 9:11 ` Jean-Jacques Hiblot
2014-06-15 14:55 ` Boris BREZILLON
2014-07-04 13:31 ` Boris BREZILLON
2014-06-09 16:04 ` [PATCH v2 3/7] drm: add Atmel HLCDC Display Controller support Boris BREZILLON
[not found] ` <539D6839.1070703@traphandler.com>
2014-06-15 15:00 ` Boris BREZILLON [this message]
2014-06-09 16:04 ` [PATCH v2 4/7] ARM: at91/dt: split sama5d3 lcd pin definitions to match RGB mode configs Boris BREZILLON
2014-06-19 7:07 ` Bo Shen
2014-06-19 7:40 ` Boris BREZILLON
2014-06-19 11:42 ` Boris BREZILLON
2014-06-09 16:04 ` [PATCH v2 5/7] ARM: at91/dt: define the HLCDC node available on sama5d3 SoCs Boris BREZILLON
2014-06-09 16:04 ` [PATCH v2 6/7] ARM: at91/dt: add LCD panel description to sama5d3xdm.dtsi Boris BREZILLON
2014-06-09 16:04 ` [PATCH v2 7/7] ARM: at91/dt: enable the LCD panel on sama5d3xek boards Boris BREZILLON
2014-06-19 7:12 ` Bo Shen
2014-06-19 7:54 ` Boris BREZILLON
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539DB51D.5080204@free-electrons.com \
--to=boris.brezillon@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox