Subject: [PATCH v2 06/10] mfd: Add driver for Maxim 77802 Power Management IC

From: [email-masked] (Javier Martinez Canillas)
Date: Wed, 18 Jun 2014 11:50:08 +0200

Hello Lee,

On 06/18/2014 10:32 AM, Lee Jones wrote:
>> >> +config MFD_MAX77802
>> >> +	tristate "Maxim Integrated MAX77802 PMIC Support"
>> >> +	depends on I2C=y
>> >> +	select MFD_CORE
>> >> +	select REGMAP_I2C
>> >> +	select REGMAP_IRQ
>> >> +	select IRQ_DOMAIN
>> >> +	help
>> >> +	  Say yes here to support for Maxim Integrated MAX77802.
>> >> +	  This is a Power Management IC with RTC on chip.
>> >> +	  This driver provides common support for accessing the device;
>> >> +	  additional drivers must be enabled in order to use the functionality
>> >> +	  of the device.
>> >> +
>> > 
>> > It is a bit unorthodox to put the build infrastructure in the same patch
>> > as the DT binding...
>> > 
>> 
>> I thought it was the opposite. That a DT binding document has to be added along
>> with the first user of the binding but I'll separate the DT doc in another patch
>> then if that is the right thing to do.
> 
> This was the 'old' method, but changed a little over a year ago.
> 
>> Thanks a lot for all your suggestions, I'll wait a little to see if there is
>> more feedback and repost a v3 addressing all the issues you pointed out.
> 
> Just re-post it.  I'll review the next version.
> 

Ok, will do. I was waiting for Krzysztof's feedback but he can review v3 as well.

Thanks a lot and best regards,
Javier