From: r.sricharan@ti•com (Sricharan R)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V3 03/16] irqchip: crossbar: introduce ti,irqs-skip to skip
Date: Mon, 23 Jun 2014 12:50:33 +0530 [thread overview]
Message-ID: <53A7D541.6090009@ti.com> (raw)
In-Reply-To: <20140621023302.GE21711@titan.lakedaemon.net>
On Saturday 21 June 2014 08:03 AM, Jason Cooper wrote:
> Sricharan,
>
> Your subject line seems truncated:
>
> "irqchip: crossbar: introduce ti,irqs-skip to skip"
>
> maybe "... Introduce DT property to skip hardwired irqs" ?
>
> Also note that you need to correct the subject line for *every* patch in
> the series wrt capitalization.
>
> I don't mind correcting it when I apply it, provided that:
>
ha, i think this got truncated unintentionally. Sorry will fix this.
> - the patch is otherwise ready
> - I only have to do it once or twice for the series
> - I never had a chance to ask since you created a rockstar patch series
> the first time out of the gate (except for capitalization).
>
> Once I've looked over the whole series, please resend with the subject
> lines corrected.
>
Ok. I will look for your comments on the rest of the patches and
resend with capitalization fix said above.
> On Mon, Jun 16, 2014 at 04:53:03PM +0530, Sricharan R wrote:
>> From: Nishanth Menon <nm@ti•com>
>>
>> When, in the system due to varied reasons, interrupts might be unusable
>> due to hardware behavior, but register maps do exist, then those interrupts
>> should be skipped while mapping irq to crossbars.
>>
>> Signed-off-by: Nishanth Menon <nm@ti•com>
>> Signed-off-by: Sricharan R <r.sricharan@ti•com>
>> ---
>> [V3] introduced ti,irqs-skip dt property to list the
>> irqs to be skipped.
>>
>> .../devicetree/bindings/arm/omap/crossbar.txt | 4 ++++
>> drivers/irqchip/irq-crossbar.c | 20 ++++++++++++++++++++
>> 2 files changed, 24 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/omap/crossbar.txt b/Documentation/devicetree/bindings/arm/omap/crossbar.txt
>> index fb88585..cfcbd52 100644
>> --- a/Documentation/devicetree/bindings/arm/omap/crossbar.txt
>> +++ b/Documentation/devicetree/bindings/arm/omap/crossbar.txt
>> @@ -17,6 +17,10 @@ Required properties:
>> so crossbar bar driver should not consider them as free
>> lines.
>>
>> +Optional properties:
>> +- ti,irqs-skip: This is similar to "ti,irqs-reserved", but are irq mappings
>> + which are not supposed to be used for errata or other reasons(virtualization).
>
> I would specifically mention SoC-specific hard-wiring of irqs here.
> Also the fact that the hardwiring unexpectedly bypasses the crossbar.
ok, that will be more easily understandable and will add that.
>
>> +
>> Examples:
>> crossbar_mpu: @4a020000 {
>> compatible = "ti,irq-crossbar";
>
> Please include a ti,irqs-skip example here.
>
ok.
>> diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
>> index 51d4b87..27049de 100644
>> --- a/drivers/irqchip/irq-crossbar.c
>> +++ b/drivers/irqchip/irq-crossbar.c
>> @@ -18,6 +18,7 @@
>>
>> #define IRQ_FREE -1
>> #define IRQ_RESERVED -2
>> +#define IRQ_SKIP -3
>> #define GIC_IRQ_START 32
>>
>> /*
>> @@ -160,6 +161,25 @@ static int __init crossbar_of_init(struct device_node *node)
>> }
>> }
>>
>> + /* Skip the ones marked as skip */
>
> This comment is redundant, perhaps "Skip irqs hardwired to bypass the
> crossbar."?
ok, will change this.
Regards,
Sricharan
next prev parent reply other threads:[~2014-06-23 7:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 11:23 [PATCH V3 00/16] irqchip: crossbar: driver fixes Sricharan R
2014-06-16 11:23 ` [PATCH V3 01/16] irqchip: crossbar: dont use '0' to mark reserved interrupts Sricharan R
2014-06-16 11:23 ` [PATCH V3 02/16] irqchip: crossbar: check for premapped crossbar before allocating Sricharan R
2014-06-16 11:23 ` [PATCH V3 03/16] irqchip: crossbar: introduce ti,irqs-skip to skip Sricharan R
2014-06-21 2:33 ` Jason Cooper
2014-06-23 7:20 ` Sricharan R [this message]
2014-06-16 11:23 ` [PATCH V3 04/16] irqchip: crossbar: initialise the crossbar with a safe value Sricharan R
2014-06-16 11:23 ` [PATCH V3 05/16] irqchip: crossbar: change allocation logic by reversing search for free irqs Sricharan R
2014-06-16 11:23 ` [PATCH V3 06/16] irqchip: crossbar: remove IS_ERR_VALUE check Sricharan R
2014-06-16 11:23 ` [PATCH V3 07/16] irqchip: crossbar: fix sparse and checkpatch warnings Sricharan R
2014-06-16 11:23 ` [PATCH V3 08/16] irqchip: crossbar: fix kerneldoc warning Sricharan R
2014-06-16 11:23 ` [PATCH V3 09/16] irqchip: crossbar: return proper error value Sricharan R
2014-06-16 11:23 ` [PATCH V3 10/16] irqchip: crossbar: change the goto naming Sricharan R
2014-06-16 11:23 ` [PATCH V3 11/16] irqchip: crossbar: set cb pointer to null in case of error Sricharan R
2014-06-16 11:23 ` [PATCH V3 12/16] irqchip: crossbar: add kerneldoc for crossbar_domain_unmap callback Sricharan R
2014-06-16 11:23 ` [PATCH V3 13/16] irqchip: crossbar: introduce ti, max-crossbar-sources to identify valid crossbar mapping Sricharan R
2014-06-16 11:23 ` [PATCH V3 14/16] irqchip: crossbar: introduce centralized check for crossbar write Sricharan R
2014-06-16 11:23 ` [PATCH V3 15/16] documentation: dt: omap: crossbar: add description for interrupt consumer Sricharan R
2014-06-16 11:23 ` [PATCH V3 16/16] irqchip: crossbar: allow for quirky hardware with direct hardwiring of GIC Sricharan R
2014-06-21 2:57 ` Jason Cooper
2014-06-23 7:22 ` Sricharan R
2014-06-16 14:04 ` [PATCH V3 00/16] irqchip: crossbar: driver fixes Santosh Shilimkar
2014-06-17 8:54 ` Sricharan R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A7D541.6090009@ti.com \
--to=r.sricharan@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox