From: emilio@elopez•com.ar (Emilio López)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 02/10] serial: 8250_dw: support DMA on the OF case
Date: Tue, 24 Jun 2014 10:19:15 -0300 [thread overview]
Message-ID: <53A97AD3.6060804@elopez.com.ar> (raw)
In-Reply-To: <CAGb2v676GgfHnR-XWdQCa-ecYtYRxePS1dgGL6QqbntUkBvi_g@mail.gmail.com>
Hi,
El 21/06/14 10:56, Chen-Yu Tsai escribi?:
> On Mon, Jun 16, 2014 at 11:50 AM, Emilio L?pez <emilio@elopez•com.ar> wrote:
>> Currently, DMA properties on the DT are ignored when using the 8250_dw
>> driver. With this patch, DMA will be used when available.
>>
>> Signed-off-by: Emilio L?pez <emilio@elopez•com.ar>
>> ---
>> drivers/tty/serial/8250/8250_dw.c | 7 ++++++-
>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
>> index ed31135..f75c0bf 100644
>> --- a/drivers/tty/serial/8250/8250_dw.c
>> +++ b/drivers/tty/serial/8250/8250_dw.c
>> @@ -222,6 +222,8 @@ static int dw8250_probe_of(struct uart_port *p,
>> struct dw8250_data *data)
>> {
>> struct device_node *np = p->dev->of_node;
>> + struct uart_8250_port *up = container_of(p, struct uart_8250_port,
>> + port);
>> u32 val;
>> bool has_ucv = true;
>>
>> @@ -254,11 +256,14 @@ static int dw8250_probe_of(struct uart_port *p,
>> }
>> }
>> if (has_ucv)
>> - dw8250_setup_port(container_of(p, struct uart_8250_port, port));
>> + dw8250_setup_port(up);
>>
>> if (!of_property_read_u32(np, "reg-shift", &val))
>> p->regshift = val;
>>
>> + if (of_get_property(np, "dmas", NULL))
>> + up->dma = &data->dma;
>> +
>
> I suggest adding a comment here. Looking just at the patch,
> it's not very intuitive. But otherwise the patch looks good.
Sure, I can do that
Thanks!
Emilio
next prev parent reply other threads:[~2014-06-24 13:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 3:50 [PATCH 00/10] DMAEngine support for sun4i, sun5i & sun7i Emilio López
2014-06-16 3:50 ` [PATCH 01/10] dma: sun4i: Add support for the DMA engine on sun[457]i SoCs Emilio López
2014-06-21 13:51 ` Chen-Yu Tsai
2014-06-24 13:02 ` Emilio López
2014-06-25 18:42 ` Maxime Ripard
2014-06-25 22:46 ` Emilio López
2014-06-29 13:23 ` Maxime Ripard
2014-06-16 3:50 ` [PATCH 02/10] serial: 8250_dw: support DMA on the OF case Emilio López
2014-06-21 13:56 ` Chen-Yu Tsai
2014-06-24 13:19 ` Emilio López [this message]
2014-06-16 3:50 ` [PATCH 03/10] spi: sun4i: add DMA support Emilio López
2014-06-25 18:48 ` Maxime Ripard
2014-06-16 3:50 ` [PATCH 04/10] ARM: sun7i: Add node to represent the DMA controller Emilio López
2014-06-16 3:50 ` [PATCH 05/10] ARM: sun4i: " Emilio López
2014-06-16 3:50 ` [PATCH 06/10] ARM: sun7i: enable DMA on SPI Emilio López
2014-06-16 3:50 ` [PATCH 07/10] ARM: sun4i: " Emilio López
2014-06-16 3:50 ` [PATCH 08/10] ARM: sun7i: add DMA properties to UARTs Emilio López
2014-06-16 3:50 ` [PATCH 09/10] ARM: sun4i: cubieboard: add an SPIdev device for testing Emilio López
2014-06-25 21:22 ` Maxime Ripard
2014-06-25 21:33 ` Emilio López
2014-06-16 3:50 ` [PATCH 10/10] ARM: sun7i: cubietruck: " Emilio López
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A97AD3.6060804@elopez.com.ar \
--to=emilio@elopez$(echo .)com.ar \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox