From: santosh.shilimkar@ti•com (Santosh Shilimkar)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC 1/4] ARM: tegra: Move SoC drivers to drivers/soc/tegra
Date: Fri, 27 Jun 2014 13:30:04 -0400 [thread overview]
Message-ID: <53ADAA1C.70407@ti.com> (raw)
In-Reply-To: <1403888329-24755-1-git-send-email-thierry.reding@gmail.com>
+Arnd, Greg, Catalin and Kumar,
On Friday 27 June 2014 12:58 PM, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia•com>
>
> These drivers are closely coupled and need to be moved as a whole. One
> reason for moving them out of arch/arm/mach-tegra is to allow them to be
> shared with 64-bit ARM.
>
> Signed-off-by: Thierry Reding <treding@nvidia•com>
> ---
> arch/arm/mach-tegra/Makefile | 32 --------
> arch/arm/mach-tegra/common.h | 4 -
> arch/arm/mach-tegra/io.c | 27 +++++-
> arch/arm/mach-tegra/pmc.h | 62 --------------
> arch/arm/mach-tegra/tegra.c | 9 --
> drivers/soc/Makefile | 1 +
> drivers/soc/tegra/Makefile | 34 ++++++++
> .../soc/tegra}/cpuidle-tegra114.c | 0
> .../soc/tegra}/cpuidle-tegra20.c | 6 +-
> .../soc/tegra}/cpuidle-tegra30.c | 0
> .../arm/mach-tegra => drivers/soc/tegra}/cpuidle.c | 0
> .../arm/mach-tegra => drivers/soc/tegra}/cpuidle.h | 3 -
> .../mach-tegra => drivers/soc/tegra}/flowctrl.c | 0
> .../mach-tegra => drivers/soc/tegra}/flowctrl.h | 2 -
> .../arm/mach-tegra => drivers/soc/tegra}/headsmp.S | 0
> .../arm/mach-tegra => drivers/soc/tegra}/hotplug.c | 0
> {arch/arm/mach-tegra => drivers/soc/tegra}/iomap.h | 0
> .../arm/mach-tegra => drivers/soc/tegra}/irammap.h | 0
> {arch/arm/mach-tegra => drivers/soc/tegra}/irq.c | 1 -
> {arch/arm/mach-tegra => drivers/soc/tegra}/irq.h | 6 --
> .../arm/mach-tegra => drivers/soc/tegra}/platsmp.c | 5 --
> .../mach-tegra => drivers/soc/tegra}/pm-tegra20.c | 0
> .../mach-tegra => drivers/soc/tegra}/pm-tegra30.c | 0
> {arch/arm/mach-tegra => drivers/soc/tegra}/pm.c | 0
> {arch/arm/mach-tegra => drivers/soc/tegra}/pm.h | 4 +-
> {arch/arm/mach-tegra => drivers/soc/tegra}/pmc.c | 0
> drivers/soc/tegra/pmc.h | 35 ++++++++
> .../mach-tegra => drivers/soc/tegra}/powergate.c | 0
> .../soc/tegra}/reset-handler.S | 0
> {arch/arm/mach-tegra => drivers/soc/tegra}/reset.c | 0
> {arch/arm/mach-tegra => drivers/soc/tegra}/reset.h | 2 -
> .../soc/tegra}/sleep-tegra20.S | 0
> .../soc/tegra}/sleep-tegra30.S | 0
> {arch/arm/mach-tegra => drivers/soc/tegra}/sleep.S | 0
> {arch/arm/mach-tegra => drivers/soc/tegra}/sleep.h | 2 -
> include/linux/tegra-soc.h | 95 ++++++++++++++++++++++
> 36 files changed, 195 insertions(+), 135 deletions(-)
> delete mode 100644 arch/arm/mach-tegra/common.h
> delete mode 100644 arch/arm/mach-tegra/pmc.h
> create mode 100644 drivers/soc/tegra/Makefile
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/cpuidle-tegra114.c (100%)
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/cpuidle-tegra20.c (100%)
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/cpuidle-tegra30.c (100%)
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/cpuidle.c (100%)
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/cpuidle.h (91%)
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/flowctrl.c (100%)
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/flowctrl.h (98%)
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/headsmp.S (100%)
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/hotplug.c (100%)
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/iomap.h (100%)
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/irammap.h (100%)
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/irq.c (99%)
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/irq.h (83%)
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/platsmp.c (98%)
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/pm-tegra20.c (100%)
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/pm-tegra30.c (100%)
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/pm.c (100%)
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/pm.h (94%)
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/pmc.c (100%)
> create mode 100644 drivers/soc/tegra/pmc.h
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/powergate.c (100%)
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/reset-handler.S (100%)
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/reset.c (100%)
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/reset.h (97%)
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/sleep-tegra20.S (100%)
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/sleep-tegra30.S (100%)
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/sleep.S (100%)
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/sleep.h (98%)
>
NAK for this patch.
You are using drivers/soc/* as a dump yard for your SOC code which
is not the intention we created drivers/soc/.
Its really for subsystem drivers which doesn't have appropriate
home in Linux kernel today. From your above patch ...
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/cpuidle-tegra114.c (100%)
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/cpuidle-tegra20.c (100%)
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/cpuidle-tegra30.c (100%)
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/cpuidle.c (100%)
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/cpuidle.h (91%)
This should go into drivers/idle/*. if you have dependencies, please sort
them out.
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/reset-handler.S (100%)
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/reset.c (100%)
> rename {arch/arm/mach-tegra => drivers/soc/tegra}/reset.h (97%)
subsystem: drivers/power/reset/
For tegra/*pm*/, you can use drivers/power or drivers/base/power/
For SMP boot, ARMv8 expecting to have either PSCI based implementation or
device tree based boot scheme. you can move towards that model if possible.
Please find appropriate subsystem to move your SOC code and if you don't
find an appropriate subsystem, we can discuss adding that under drivers/soc.
The drivers/soc/* isn't a dumping ground so please don't abuse it.
regards,
Santosh
next prev parent reply other threads:[~2014-06-27 17:30 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-27 16:58 [RFC 1/4] ARM: tegra: Move SoC drivers to drivers/soc/tegra Thierry Reding
2014-06-27 16:58 ` [RFC 2/4] ARM: tegra: Add legacy interrupt controller nodes Thierry Reding
2014-06-27 20:58 ` Stephen Warren
2014-06-27 23:44 ` Thierry Reding
2014-06-27 16:58 ` [RFC 3/4] soc/tegra: Initialize interrupt controller from DT Thierry Reding
2014-06-27 21:03 ` Stephen Warren
2014-06-28 1:12 ` Thierry Reding
2014-06-30 11:30 ` Peter De Schrijver
2014-06-30 19:51 ` Thierry Reding
2014-06-27 16:58 ` [RFC 4/4] soc/tegra: Remove unused defines Thierry Reding
2014-06-27 21:03 ` Stephen Warren
2014-06-28 1:12 ` Thierry Reding
2014-06-27 17:30 ` Santosh Shilimkar [this message]
2014-06-27 23:27 ` [RFC 1/4] ARM: tegra: Move SoC drivers to drivers/soc/tegra Thierry Reding
2014-06-28 17:15 ` Santosh Shilimkar
2014-06-28 20:40 ` Thierry Reding
2014-06-30 7:20 ` Arnd Bergmann
2014-06-30 9:01 ` Thierry Reding
2014-06-30 10:36 ` Catalin Marinas
2014-06-30 10:48 ` Thierry Reding
2014-06-30 13:16 ` Lorenzo Pieralisi
2014-06-30 19:36 ` Thierry Reding
2014-07-01 10:50 ` Catalin Marinas
2014-07-01 15:05 ` Stephen Warren
2014-07-01 17:00 ` Catalin Marinas
2014-06-30 19:21 ` Thierry Reding
2014-07-01 7:51 ` Peter De Schrijver
2014-07-16 19:31 ` Olof Johansson
2014-07-16 19:47 ` Thierry Reding
2014-07-17 9:31 ` Catalin Marinas
2014-07-17 16:21 ` Olof Johansson
2014-06-30 7:23 ` Arnd Bergmann
2014-06-30 9:44 ` Catalin Marinas
2014-06-30 18:45 ` Stephen Warren
2014-06-30 10:25 ` Catalin Marinas
2014-06-30 10:49 ` Thierry Reding
2014-06-30 11:46 ` Peter De Schrijver
2014-06-30 14:13 ` Catalin Marinas
2014-06-30 14:42 ` Peter De Schrijver
2014-06-30 14:50 ` Peter De Schrijver
2014-06-30 16:08 ` Catalin Marinas
2014-06-27 21:10 ` Stephen Warren
2014-06-28 1:24 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53ADAA1C.70407@ti.com \
--to=santosh.shilimkar@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox