From: cov@codeaurora•org (Christopher Covington)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 0/8] arm: perf: cleanups and initial refactoring
Date: Wed, 02 Jul 2014 08:46:19 -0400 [thread overview]
Message-ID: <53B3FF1B.2090202@codeaurora.org> (raw)
In-Reply-To: <1404227478-9645-1-git-send-email-mark.rutland@arm.com>
Hi Mark,
On 07/01/2014 11:11 AM, Mark Rutland wrote:
> While reorganising the ARM perf backend to provide support for
> heterogeneous PMUs in big.LITTLE systems, I encountered a couple of
> issues requiring some preparatory work in addition to some opportunities
> for general cleanup in the backend. This series consists of those
> initial cleanups.
>
> Currently the event mapping code in the ARM perf backend requires
> multi-dimensional tables to map from common event encodings to raw
> hardware values, where empty slots must be initialised to non-zero
> values. The current way of organising this results in very large support
> files which we can simplify with some macro use to remove a few hundred
> lines and make things more legible.
>
> The PMU naming is somewhat of a mess, with most names not being
> supported by the perf tool. Given that no-one has complained, it seems
> that the PMUs are not being accessed by name in a perf context, and we
> can fix these to be consistent and usable with current tools. We update
> the OProfile name mangling to ensure that OProfile (which accesses the
> PMUs in its own namespace) are not adversely affected.
>
> To prepare for reorganisation of the PMU probing code, new
> platform_device_id values are added to allow ARMv6, ARMv7, and XScale
> PMU platform_devices to be distinguished.
I ran Vince Weaver's perf events test suite [1] against a kernel with these
patches applied on an 8074 Dragonboard [2] and didn't see any regressions. The
patches also look good to me.
Tested-by: Christopher Covington <cov@codeaurora•org>
1. https://github.com/deater/perf_event_tests
2. http://elinux.org/Dragonboard/APQ8074
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by the Linux Foundation.
next prev parent reply other threads:[~2014-07-02 12:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 15:11 [PATCH 0/8] arm: perf: cleanups and initial refactoring Mark Rutland
2014-07-01 15:11 ` [PATCH 1/8] arm: perf: move event map macros to pmu.h Mark Rutland
2014-07-01 15:11 ` [PATCH 2/8] arm: perf: add macros for empty event mappings Mark Rutland
2014-07-01 15:11 ` [PATCH 3/8] arm: perf: armv7: condense event maps Mark Rutland
2014-07-01 15:11 ` [PATCH 4/8] arm: perf: armv6: " Mark Rutland
2014-07-01 15:11 ` [PATCH 5/8] arm: perf: xscale: " Mark Rutland
2014-07-01 15:11 ` [PATCH 6/8] arm: perf: clean up PMU names Mark Rutland
2014-07-01 15:11 ` [PATCH 7/8] arm: perf: add more specific platform device IDs Mark Rutland
2014-07-01 18:06 ` Will Deacon
2014-07-01 15:11 ` [PATCH 8/8] arm: perf: krait: stop using singleton PMU Mark Rutland
2014-07-01 17:40 ` Stephen Boyd
2014-07-01 18:06 ` Will Deacon
2014-07-02 12:46 ` Christopher Covington [this message]
2014-07-02 14:45 ` [PATCH 0/8] arm: perf: cleanups and initial refactoring Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B3FF1B.2090202@codeaurora.org \
--to=cov@codeaurora$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox