From: mperttunen@nvidia•com (Mikko Perttunen)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/6] thermal: of: Add support for hardware-tracked trip points
Date: Thu, 3 Jul 2014 17:15:36 +0300 [thread overview]
Message-ID: <53B56588.6090703@nvidia.com> (raw)
In-Reply-To: <53B2FADC.8060708@wwwdotorg.org>
On 01/07/14 21:15, Stephen Warren wrote:
>> The thermal core only supports a fixed number of trip points for each
>> driver and the core informs the driver of any changes to those, so
>> drivers using the core framework can already have hardware trip points,
>> but just a fixed number of them.
>>
>> The way of-thermal works, is it reads all the trip points from the
>> device tree, registers a new thermal_zone_device with that number of
>> trip points and then handles the trip points completely independently.
>> Of course, if we're just polling, this is fine, since the thermal core
>> also knows about those trip points and will trigger cooling when polling
>> the each zone. However, the driver doesn't, so it cannot setup any
>> interrupts to call thermal_zone_device_update.
>
> Is there any possibility of cleaning that up? It's obviously horribly
> inconsistent if core driver functionality works completely differently
> simply because the list of trip-points comes from DT rather than a
> static table in the driver. of_thermal should be limited to DT parsing
> and related device instantiation/lookup, not introducing a completely
> different functionality model.
I guess the smallest possible change would be to add a
#hardware-trip-cells property to the thermal driver node (this would
need to designate both the thermal zone and the trip point) and a
hardware-trip-point phandle node to trip points. Then trip points could
point to a hardware trip point that would get programmed. Since this is
just adding properties, it would be backwards-compatible as well.
This is starting to sound like a good idea. Will have to give think
about it some more.
next prev parent reply other threads:[~2014-07-03 14:15 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-27 8:11 [PATCH 0/6] of-thermal hardware trip points + Tegra124 SOCTHERM driver Mikko Perttunen
2014-06-27 8:11 ` [PATCH 1/6] thermal: of: Add support for hardware-tracked trip points Mikko Perttunen
2014-06-30 21:08 ` Stephen Warren
2014-07-01 7:27 ` Mikko Perttunen
2014-07-01 18:15 ` Stephen Warren
2014-07-03 14:15 ` Mikko Perttunen [this message]
2014-07-30 14:16 ` Eduardo Valentin
2014-08-01 11:42 ` Mikko Perttunen
2014-08-01 13:15 ` edubezval at gmail.com
2014-06-27 8:11 ` [PATCH 2/6] of: Add bindings for nvidia,tegra124-soctherm Mikko Perttunen
2014-06-30 20:40 ` Stephen Warren
2014-06-27 8:11 ` [PATCH 3/6] ARM: tegra: Add thermal trip points for Jetson TK1 Mikko Perttunen
2014-06-30 20:45 ` Stephen Warren
2014-06-27 8:11 ` [PATCH 4/6] ARM: tegra: Add soctherm and thermal zones to Tegra124 device tree Mikko Perttunen
2014-06-30 20:48 ` Stephen Warren
2014-07-01 7:49 ` Mikko Perttunen
2014-07-21 23:13 ` Matthew Longnecker
2014-06-27 8:11 ` [PATCH 5/6] clk: tegra: Add soctherm and tsensor clocks to Tegra124 init table Mikko Perttunen
2014-06-27 12:18 ` Peter De Schrijver
2014-06-27 8:11 ` [PATCH 6/6] thermal: Add Tegra SOCTHERM thermal management driver Mikko Perttunen
2014-06-30 21:23 ` Stephen Warren
2014-07-01 8:06 ` Mikko Perttunen
2014-07-01 18:26 ` Stephen Warren
2014-07-03 13:51 ` Mikko Perttunen
2014-07-01 23:47 ` Tuomas Tynkkynen
2014-07-04 8:43 ` Wei Ni
2014-07-04 11:52 ` Mikko Perttunen
2014-07-21 7:42 ` [PATCH 0/6] of-thermal hardware trip points + Tegra124 SOCTHERM driver Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B56588.6090703@nvidia.com \
--to=mperttunen@nvidia$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox