From: t.figa@samsung•com (Tomasz Figa)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/6] pinctrl: samsung: Handle GPIO request and free using pinctrl helpers
Date: Fri, 04 Jul 2014 13:00:36 +0200 [thread overview]
Message-ID: <53B68954.30300@samsung.com> (raw)
In-Reply-To: <CAK5sBcFHFg7u-40NVovp9D2ro=MnQbOyiP6MtMss2PJmByR4iQ@mail.gmail.com>
On 04.07.2014 11:41, Sachin Kamat wrote:
> Hi Tomasz,
>
> On Wed, Jul 2, 2014 at 9:11 PM, Tomasz Figa <t.figa@samsung•com> wrote:
>> This patch adds .request() and .free() operations to gpio_chip of
>> pinctrl-samsung driver, which call pinctrl request and free helpers to
>> request and free pinctrl pin along with GPIO pin.
>>
>> Signed-off-by: Tomasz Figa <t.figa@samsung•com>
>> ---
>> drivers/pinctrl/pinctrl-samsung.c | 15 ++++++++++++++-
>> 1 file changed, 14 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/pinctrl/pinctrl-samsung.c b/drivers/pinctrl/pinctrl-samsung.c
>> index 779c8bc..6e099d6 100644
>> --- a/drivers/pinctrl/pinctrl-samsung.c
>> +++ b/drivers/pinctrl/pinctrl-samsung.c
>> @@ -779,7 +779,8 @@ static int samsung_pinctrl_register(struct platform_device *pdev,
>> pin_bank = &drvdata->ctrl->pin_banks[bank];
>> pin_bank->grange.name = pin_bank->name;
>> pin_bank->grange.id = bank;
>> - pin_bank->grange.pin_base = pin_bank->pin_base;
>> + pin_bank->grange.pin_base = drvdata->ctrl->base
>> + + pin_bank->pin_base;
>
> Is this a fix?
>
Hmm, could be.
I haven't observed any issues due to this without further patches from
this series, so I'm not sure if this needs to be sent as a separate fix,
but I might split this patch into two if necessary.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-07-04 11:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 15:40 [PATCH 0/6] Various improvements for samsung-pinctrl driver Tomasz Figa
2014-07-02 15:40 ` [PATCH 1/6] pinctrl: samsung: Decouple direction setting from pinctrl Tomasz Figa
2014-07-08 8:54 ` Linus Walleij
2014-07-02 15:41 ` [PATCH 2/6] pinctrl: samsung: Handle GPIO request and free using pinctrl helpers Tomasz Figa
2014-07-04 9:41 ` Sachin Kamat
2014-07-04 11:00 ` Tomasz Figa [this message]
2014-07-08 8:57 ` Linus Walleij
2014-07-02 15:41 ` [PATCH 3/6] pinctrl: exynos: Consolidate irq_chips of GPIO and WKUP EINTs Tomasz Figa
2014-07-08 8:59 ` Linus Walleij
2014-07-02 15:41 ` [PATCH 4/6] pinctrl: exynos: Lock GPIOs as interrupts when used as EINTs Tomasz Figa
2014-07-08 9:03 ` Linus Walleij
2014-07-08 10:50 ` Tomasz Figa
2014-07-02 15:41 ` [PATCH 5/6] pinctrl: samsung: Allow grouping multiple pinmux/pinconf nodes Tomasz Figa
2014-07-09 7:32 ` Linus Walleij
2014-07-09 8:06 ` Tomasz Figa
2014-07-02 15:41 ` [PATCH 6/6] pinctrl: samsung: Allow pin value to be initialized using pinfunc Tomasz Figa
2014-07-09 7:35 ` Linus Walleij
2014-07-09 8:07 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B68954.30300@samsung.com \
--to=t.figa@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox