From: kgene.kim@samsung•com (Kukjin Kim)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 05/17] pwm: samsung: remove s5p64x0 related pwm codes
Date: Tue, 08 Jul 2014 07:23:25 +0900 [thread overview]
Message-ID: <53BB1DDD.1020307@samsung.com> (raw)
In-Reply-To: <53B6618A.3050504@gmail.com>
On 07/04/14 17:10, Tomasz Figa wrote:
> Hi Kukjin,
>
Tomasz,
> On 30.06.2014 23:32, Kukjin Kim wrote:
>> This patch removes supporting s5p64x0 related pwm codes because of
>> no more support for S5P6440 and S5P6450 SoCs. And this patch changes
>> the name of s5p6440-pwm to exynos-pwm instead.
>>
>> Signed-off-by: Kukjin Kim<kgene.kim@samsung•com>
>> Cc: Thierry Reding<thierry.reding@gmail•com>
>> ---
>> Documentation/devicetree/bindings/pwm/pwm-samsung.txt | 1 -
>> arch/arm/boot/dts/exynos4210-universal_c210.dts | 2 +-
>> drivers/clocksource/samsung_pwm_timer.c | 13 -------------
>> drivers/pwm/pwm-samsung.c | 5 ++---
>> 4 files changed, 3 insertions(+), 18 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pwm/pwm-samsung.txt b/Documentation/devicetree/bindings/pwm/pwm-samsung.txt
>> index 5538de9..43925d3 100644
>> --- a/Documentation/devicetree/bindings/pwm/pwm-samsung.txt
>> +++ b/Documentation/devicetree/bindings/pwm/pwm-samsung.txt
>> @@ -11,7 +11,6 @@ Required properties:
>> - compatible : should be one of following:
>> samsung,s3c2410-pwm - for 16-bit timers present on S3C24xx SoCs
>> samsung,s3c6400-pwm - for 32-bit timers present on S3C64xx SoCs
>> - samsung,s5p6440-pwm - for 32-bit timers present on S5P64x0 SoCs
>> samsung,s5pc100-pwm - for 32-bit timers present on S5PC100, S5PV210,
>> Exynos4210 rev0 SoCs
>> samsung,exynos4210-pwm - for 32-bit timers present on Exynos4210,
>> diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm/boot/dts/exynos4210-universal_c210.dts
>> index d50eb3a..0ca26e0 100644
>> --- a/arch/arm/boot/dts/exynos4210-universal_c210.dts
>> +++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts
>> @@ -461,7 +461,7 @@
>> };
>>
>> pwm at 139D0000 {
>> - compatible = "samsung,s5p6440-pwm";
>> + compatible = "samsung,exynos4210-pwm";
>
> There is a reason to use a different compatible string for Exynos4210
> rev0. The PWM block is used as a timer there, while on newer revs MCT is
> used. Sorry, but I have to NAK this patch.
>
I remember why exynos4210-universal_c210 uses PWM...OK.
> As I explained in my reply to patch 11/17, I'd suggest keeping the PWM
> drivers as is, because there is no need to remove support for DT
> compatible strings.
>
OK, let me remove pwm related patches in this series but I think need to
update the compatible strings, at least remove non-support SoC in doc?...
Thanks,
Kukjin
next prev parent reply other threads:[~2014-07-07 22:23 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 21:32 [PATCH 00/17] ARM: S5P64X0, S5PC100: no more support in mainline Kukjin Kim
2014-06-30 13:34 ` Arnd Bergmann
2014-06-30 14:22 ` Thierry Reding
2014-06-30 14:31 ` Arnd Bergmann
2014-07-01 2:08 ` Kukjin Kim
2014-06-30 15:31 ` Tushar Behera
2014-07-01 2:08 ` Kukjin Kim
2014-06-30 21:32 ` [PATCH 02/17] gpio: samsung: remove s5p64x0 related gpio codes Kukjin Kim
2014-07-07 16:05 ` Linus Walleij
2014-06-30 21:32 ` [PATCH 03/17] spi: s3c64xx: remove s5p64x0 related spi codes Kukjin Kim
2014-06-30 21:32 ` [PATCH 04/17] ASoC: samsung: no more support for S5P6440 and S5P6450 SoCs Kukjin Kim
2014-06-30 21:32 ` [PATCH 05/17] pwm: samsung: remove s5p64x0 related pwm codes Kukjin Kim
2014-07-04 8:10 ` Tomasz Figa
2014-07-07 22:23 ` Kukjin Kim [this message]
2014-07-08 15:43 ` Tomasz Figa
2014-06-30 21:32 ` [PATCH 06/17] video: fbdev: s3c-fb: remove s5p64x0 related fimd codes Kukjin Kim
2014-07-01 2:04 ` Jingoo Han
2014-07-01 6:25 ` Tomi Valkeinen
2014-06-30 21:32 ` [PATCH 07/17] serial: samsung: no more support for S5P6440 and S5P6450 SoCs Kukjin Kim
2014-06-30 21:32 ` [PATCH 09/17] gpio: samsung: remov s5pc100 related gpio codes Kukjin Kim
2014-07-07 16:05 ` Linus Walleij
2014-06-30 21:32 ` [PATCH 10/17] spi: s3c64xx: remove s5pc100 related spi codes Kukjin Kim
2014-06-30 21:32 ` [PATCH 11/17] pwm: samsung: remove s5pc100 related pwm codes Kukjin Kim
2014-07-03 12:44 ` Tomasz Figa
2014-07-04 7:32 ` Kukjin Kim
2014-07-04 8:07 ` Tomasz Figa
2014-06-30 21:32 ` [PATCH 12/17] serial: samsung: no more support for S5PC100 SoC Kukjin Kim
2014-06-30 21:32 ` [PATCH 13/17] ata: pata_samsung_cf: removes s5pc100 related ata codes Kukjin Kim
2014-06-30 14:49 ` Tejun Heo
2014-06-30 21:32 ` [PATCH 14/17] mtd: onenand: remove s5pc100 related onenand codes Kukjin Kim
2014-07-12 7:12 ` Brian Norris
2014-06-30 21:32 ` [PATCH 15/17] video: fbdev: s3c-fb: remove s5pc100 related fimd and fb codes Kukjin Kim
2014-07-01 2:05 ` Jingoo Han
2014-06-30 21:32 ` [PATCH 16/17] [media] exynos4-is: removes s5pc100 related fimc codes Kukjin Kim
2014-06-30 14:03 ` Sylwester Nawrocki
2014-06-30 21:32 ` [PATCH 17/17] ASoC: Samsung: remove s5pc100 related codes Kukjin Kim
2014-07-14 18:05 ` Mark Brown
2014-07-02 18:02 ` [PATCH 00/17] ARM: S5P64X0, S5PC100: no more support in mainline Tomasz Figa
2014-07-02 22:46 ` Kukjin Kim
2014-07-03 3:35 ` Sachin Kamat
2014-07-04 8:43 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BB1DDD.1020307@samsung.com \
--to=kgene.kim@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox