From: kgene.kim@samsung•com (Kukjin Kim)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v6 2/6] ARM: EXYNOS: Move cpufreq and cpuidle device registration to init_machine
Date: Tue, 08 Jul 2014 07:56:55 +0900 [thread overview]
Message-ID: <53BB25B7.6000500@samsung.com> (raw)
In-Reply-To: <1404705056-11965-3-git-send-email-pankaj.dubey@samsung.com>
On 07/07/14 12:50, Pankaj Dubey wrote:
> As exynos_cpuidle_init and exynos_cpufreq_init function have just one lines
> of code for registering platform devices. We can move these lines to
> exynos_dt_machine_init and delete exynos_cpuidle_init and exynos_cpufreq_init
> function. This will help in reducing lines of code in exynos.c, making it
> more cleaner.
>
> Suggested-by: Tomasz Figa<t.figa@samsung•com>
> Signed-off-by: Pankaj Dubey<pankaj.dubey@samsung•com>
> Reviewed-by: Tomasz Figa<t.figa@samsung•com>
> ---
> arch/arm/mach-exynos/exynos.c | 20 ++++----------------
> 1 file changed, 4 insertions(+), 16 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
> index ff60b4c..47170eb 100644
> --- a/arch/arm/mach-exynos/exynos.c
> +++ b/arch/arm/mach-exynos/exynos.c
> @@ -171,19 +171,6 @@ static struct platform_device exynos_cpuidle = {
> .id = -1,
> };
>
> -void __init exynos_cpuidle_init(void)
> -{
> - if (soc_is_exynos5440())
> - return;
> -
> - platform_device_register(&exynos_cpuidle);
> -}
> -
> -void __init exynos_cpufreq_init(void)
> -{
> - platform_device_register_simple("exynos-cpufreq", -1, NULL, 0);
> -}
> -
> void __iomem *sysram_base_addr;
> void __iomem *sysram_ns_base_addr;
>
> @@ -300,10 +287,11 @@ static void __init exynos_dt_machine_init(void)
> if (!IS_ENABLED(CONFIG_SMP))
> exynos_sysram_init();
>
> - if (!of_machine_is_compatible("samsung,exynos5420"))
> - exynos_cpuidle_init();
> + if (!of_machine_is_compatible("samsung,exynos5420") ||
> + !of_machine_is_compatible("samsung,exynos5440"))
> + platform_device_register(&exynos_cpuidle);
>
> - exynos_cpufreq_init();
> + platform_device_register_simple("exynos-cpufreq", -1, NULL, 0);
>
> of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
> }
This cannot be applied in my tree now....
- Kukjin
next prev parent reply other threads:[~2014-07-07 22:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 3:50 [PATCH v6 0/6] Cleanup patches for mach-exynos Pankaj Dubey
2014-07-07 3:50 ` [PATCH v6 1/6] ARM: EXYNOS: Make exynos machine_ops as static Pankaj Dubey
2014-07-07 3:50 ` [PATCH v6 2/6] ARM: EXYNOS: Move cpufreq and cpuidle device registration to init_machine Pankaj Dubey
2014-07-07 22:56 ` Kukjin Kim [this message]
2014-07-08 7:35 ` Pankaj Dubey
2014-07-10 13:33 ` Kukjin Kim
2014-07-14 4:10 ` Pankaj Dubey
2014-07-07 3:50 ` [PATCH v6 3/6] ARM: EXYNOS: Move SYSREG definition into sys-reg specific file Pankaj Dubey
2014-07-07 3:50 ` [PATCH v6 4/6] ARM: EXYNOS: Remove file path from comment section Pankaj Dubey
2014-07-07 3:50 ` [PATCH v6 5/6] ARM: EXYNOS: Remove regs-pmu.h header dependency from pm_domain Pankaj Dubey
2014-07-07 3:50 ` [PATCH v6 6/6] ARM: EXYNOS: Remove "linux/bug.h" from pmu.c Pankaj Dubey
2014-07-07 22:48 ` [PATCH v6 0/6] Cleanup patches for mach-exynos Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BB25B7.6000500@samsung.com \
--to=kgene.kim@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox