From: Andrew.Jackson@arm•com (Andrew Jackson)
To: linux-arm-kernel@lists•infradead.org
Subject: [alsa-devel] [PATCH v2] ASoC: tda998x: add a codec to the HDMI transmitter
Date: Tue, 08 Jul 2014 10:17:58 +0100 [thread overview]
Message-ID: <53BBB746.1000201@arm.com> (raw)
In-Reply-To: <20140704091733.10258cfe@armhf>
On 07/04/14 08:17, Jean-Francois Moine wrote:
> This patch adds a CODEC function to the NXP TDA998x HDMI transmitter.
>
> The CODEC handles both I2S and S/PDIF input and does dynamic input
> switch in the TDA998x I2C driver on start/stop audio streaming.
>
> Signed-off-by: Jean-Francois Moine <moinejf@free•fr>
> ---
[snip]
> +++ b/drivers/gpu/drm/i2c/tda998x_codec.c
[snip]
> +static int tda_startup(struct snd_pcm_substream *substream,
> + struct snd_soc_dai *dai)
> +{
> + struct tda998x_priv *priv = snd_soc_codec_get_drvdata(dai->codec);
> + u8 *eld = priv->eld;
> + struct snd_pcm_runtime *runtime = substream->runtime;
> + u8 *sad;
> + int sad_count;
> + unsigned eld_ver, mnl, rate_mask;
> + unsigned max_channels, fmt;
> + u64 formats;
> + struct snd_pcm_hw_constraint_list *rate_constraints =
> + &priv->rate_constraints;
> + static const u32 hdmi_rates[] = {
> + 32000, 44100, 48000, 88200, 9600, 176400, 192000
> + };
> +
Shouldn't this be 96000, not 9600? Assuming that the table is ordered in terms of increasing frequencies.
Andrew
next prev parent reply other threads:[~2014-07-08 9:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 7:17 [PATCH v2] ASoC: tda998x: add a codec to the HDMI transmitter Jean-Francois Moine
2014-07-08 9:17 ` Andrew Jackson [this message]
2014-07-08 9:39 ` [alsa-devel] " Jean-Francois Moine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BBB746.1000201@arm.com \
--to=andrew.jackson@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox