From: t.figa@samsung•com (Tomasz Figa)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v6 3/4] ARM: EXYNOS: Add platform driver support for Exynos PMU
Date: Tue, 08 Jul 2014 16:31:36 +0200 [thread overview]
Message-ID: <53BC00C8.4000204@samsung.com> (raw)
In-Reply-To: <1404710376-16448-4-git-send-email-pankaj.dubey@samsung.com>
Hi Pankaj,
Just one comment I already had to previous version.
On 07.07.2014 07:19, Pankaj Dubey wrote:
[snip]
> -static void exynos5_init_pmu(void)
> +static void exynos5_powerdown_conf(enum sys_powerdown mode)
> {
> unsigned int i;
> unsigned int tmp;
> @@ -382,51 +398,143 @@ void exynos_sys_powerdown_conf(enum sys_powerdown mode)
> {
> unsigned int i;
>
> - if (soc_is_exynos5250())
> - exynos5_init_pmu();
> + const struct exynos_pmu_data *pmu_data = pmu_context->pmu_data;
> +
> + if (!pmu_data)
> + return;
As I mentioned in my reply to previous version, I don't think there is
any point in probing this driver when there is no pmu_data. AFAIK the
generic syscon driver can take over in such case.
After fixing this, feel free to add
Reviewed-by: Tomasz Figa <t.figa@samsung•com>
--
Best regards,
Tomasz
next prev parent reply other threads:[~2014-07-08 14:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 5:19 [PATCH v6 0/4] ARM: Exynos: PMU cleanup and refactoring for using DT Pankaj Dubey
2014-07-07 5:19 ` [PATCH v6 1/4] ARM: EXYNOS: Add support for mapping PMU base address via DT Pankaj Dubey
2014-07-08 14:25 ` Tomasz Figa
2014-07-07 5:19 ` [PATCH v6 2/4] ARM: EXYNOS: Refactored code for using PMU " Pankaj Dubey
2014-07-08 14:28 ` Tomasz Figa
2014-07-07 5:19 ` [PATCH v6 3/4] ARM: EXYNOS: Add platform driver support for Exynos PMU Pankaj Dubey
2014-07-08 14:31 ` Tomasz Figa [this message]
2014-07-07 5:19 ` [PATCH v6 4/4] ARM: EXYNOS: Move PMU specific definitions from common.h Pankaj Dubey
2014-07-08 14:31 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BC00C8.4000204@samsung.com \
--to=t.figa@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox