From: kgene.kim@samsung•com (Kukjin Kim)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2] ARM: EXYNOS: Fix build with PM_SLEEP=n
Date: Sat, 19 Jul 2014 04:42:34 +0900 [thread overview]
Message-ID: <53C978AA.9090603@samsung.com> (raw)
In-Reply-To: <53C66924.3010303@samsung.com>
On 07/16/14 20:59, Tomasz Figa wrote:
> Hi Krzysztof,
>
> On 14.07.2014 09:45, Krzysztof Kozlowski wrote:
>> Fix building of exynos defconfig with disabled PM_SLEEP:
>> CONFIG_PM_SLEEP=n
>> CONFIG_PM_SLEEP_SMP=n
>> CONFIG_SUSPEND=n
>> by moving functions for power up/down of CPU and cluster to platsmp.c
>>
>> The build error messages:
>> arch/arm/mach-exynos/built-in.o: In function `exynos_boot_secondary':
>> arch/arm/mach-exynos/platsmp.c:111: undefined reference to `exynos_cpu_power_state'
>> arch/arm/mach-exynos/platsmp.c:112: undefined reference to `exynos_cpu_power_up'
>> arch/arm/mach-exynos/platsmp.c:116: undefined reference to `exynos_cpu_power_state'
>> make: *** [vmlinux] Error 1
>>
>> Signed-off-by: Krzysztof Kozlowski<k.kozlowski@samsung•com>
>>
>> ---
>> Changes since v1:
>> 1. Use different solution - just move the power up/down functions to a
>> common place instead of adding stubs in common.h. Suggested by Tomasz
>> Figa.
>> ---
>> arch/arm/mach-exynos/platsmp.c | 66 ++++++++++++++++++++++++++++++++++++++++++
>> arch/arm/mach-exynos/pm.c | 66 ------------------------------------------
>> 2 files changed, 66 insertions(+), 66 deletions(-)
>>
>
+ Bart,
> Reviewed-by: Tomasz Figa<t.figa@samsung•com>
>
Applied, thanks.
Bart, I think this is better at this moment to fix the build breakage
with disabling PM...if you have any comments, please let me know.
Thanks,
Kukjin
next prev parent reply other threads:[~2014-07-18 19:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 7:45 [PATCH v2] ARM: EXYNOS: Fix build with PM_SLEEP=n Krzysztof Kozlowski
2014-07-16 11:59 ` Tomasz Figa
2014-07-18 19:42 ` Kukjin Kim [this message]
2014-07-21 10:38 ` Bartlomiej Zolnierkiewicz
2014-07-21 11:11 ` Bartlomiej Zolnierkiewicz
2014-07-21 12:55 ` Bartlomiej Zolnierkiewicz
2014-07-21 13:41 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C978AA.9090603@samsung.com \
--to=kgene.kim@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox