From: afaerber@suse•de (Andreas Färber)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v8 3/6] ARM: dts: Exynos: add CPU OPP and regulator supply property
Date: Tue, 29 Jul 2014 14:42:51 +0200 [thread overview]
Message-ID: <53D796CB.5020805@suse.de> (raw)
In-Reply-To: <CAJuA9ag1xHm=vaXxXzj7ykKxYHxBndDsOTwN0vRdXvhb_DtQ2g@mail.gmail.com>
Hi Thomas,
Am 29.07.2014 14:35, schrieb Thomas Abraham:
> On Tue, Jul 29, 2014 at 5:38 PM, Andreas F?rber <afaerber@suse•de> wrote:
>> Am 29.07.2014 07:28, schrieb Thomas Abraham:
>>> diff --git a/arch/arm/boot/dts/exynos5250-cros-common.dtsi b/arch/arm/boot/dts/exynos5250-cros-common.dtsi
>>> index 89ac90f..34bb31c 100644
>>> --- a/arch/arm/boot/dts/exynos5250-cros-common.dtsi
>>> +++ b/arch/arm/boot/dts/exynos5250-cros-common.dtsi
>>> @@ -19,6 +19,12 @@
>>> chosen {
>>> };
>>>
>>> + cpus {
>>> + cpu at 0 {
>>> + cpu0-supply = <&buck2_reg>;
>>> + };
>>> + };
>>> +
>>> pinctrl at 11400000 {
>>> /*
>>> * Disabled pullups since external part has its own pullups and
>>
>> I've been instructed to dismantle this .dtsi file, so please place this
>> into exynos5250-snow.dts. It's probably wrong here anyway, since Spring
>> doesn't use the max77686 but an s5m6787 PMIC.
>
> Ok, I will move this to exynos5250-snow.dts.
>
>>
>> How do I find out which -supply to specify here for Spring?
>
> This information can be found in the Spring board schematic.
Are those available publicly somewhere? I guess not...
>> Also, wouldn't it make sense to assign a cpu0 label in exynos????.dtsi
>> to override it via &cpu0 { ... };?
>
> Sorry, I did not understand the question.
Instead of adding
cpus { cpu at 0 { ... }; };
to the board's / node, I am suggesting you do in the SoC's .dtsi:
- cpu at 0 {
+ cpu0: cpu at 0 {
and then in the board's file after / { ... }; add the following:
&cpu0 {
cpu0-supply = <&buck2_reg>;
};
This is the new preferred way to override or extend inherited nodes, I
am told. (&cpu0 should be inserted in alphabetical order then.)
Cheers,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg
next prev parent reply other threads:[~2014-07-29 12:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 5:28 [PATCH v8 0/6] cpufreq: use generic cpufreq drivers for exynos platforms Thomas Abraham
2014-07-29 5:28 ` [PATCH v8 1/6] clk: samsung: add infrastructure to register cpu clocks Thomas Abraham
2014-07-29 10:07 ` Tomasz Figa
2014-07-29 5:28 ` [PATCH v8 2/6] clk: samsung: add cpu clock configuration data and instantiate cpu clock Thomas Abraham
2014-07-29 10:13 ` Tomasz Figa
2014-07-29 11:46 ` Thomas Abraham
2014-07-29 12:04 ` Tomasz Figa
2014-07-29 12:05 ` Thomas Abraham
2014-07-29 5:28 ` [PATCH v8 3/6] ARM: dts: Exynos: add CPU OPP and regulator supply property Thomas Abraham
2014-07-29 10:31 ` Tomasz Figa
2014-07-29 12:00 ` Thomas Abraham
2014-07-29 12:10 ` Tomasz Figa
2014-07-29 12:08 ` Andreas Färber
2014-07-29 12:35 ` Thomas Abraham
2014-07-29 12:42 ` Andreas Färber [this message]
2014-07-29 12:51 ` Thomas Abraham
2014-07-29 5:28 ` [PATCH v8 4/6] ARM: Exynos: switch to using generic cpufreq driver for Exynos4210/5250/5420 Thomas Abraham
2014-07-29 10:32 ` Tomasz Figa
2014-07-29 5:28 ` [PATCH v8 5/6] cpufreq: exynos: remove exynos4210/5250 specific cpufreq driver support Thomas Abraham
2014-07-29 10:34 ` Tomasz Figa
2014-07-29 5:28 ` [PATCH v8 6/6] clk: samsung: remove unused clock aliases and update clock flags Thomas Abraham
2014-07-29 10:44 ` Tomasz Figa
2014-07-29 12:04 ` Thomas Abraham
2014-07-29 12:11 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D796CB.5020805@suse.de \
--to=afaerber@suse$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox