From: marc.zyngier@arm•com (Marc Zyngier)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v15 01/12] irq: gic: support hip04 gic
Date: Tue, 29 Jul 2014 14:41:22 +0100 [thread overview]
Message-ID: <53D7A482.7050705@arm.com> (raw)
In-Reply-To: <2455679.mpY3ZEfao6@wuerfel>
On 29/07/14 14:05, Arnd Bergmann wrote:
> On Monday 28 July 2014 18:38:58 Marc Zyngier wrote:
>> Overall, this code should be able to sitting within a #ifdef/#endif
>> block, only selected if this platform is enabled, and possibly find a
>> way not to impact all the other platforms when this is not selected.
>>
>> Finally, I'd like to outline how much I dislike the way the GIC
>> architecture has been abused here. Yes, this solves a particular
>> problem, at a given point in time, but this also feels extremely short
>> sighted from whoever has put this thing together. This really feels like
>> a short-term HW hack that is already addressed by GICv3. Merging support
>> for non architecture compliant HW is never the best solution.
>
> Not merging support for shipping hardware is also not a solution,
> and we already support any number of irqchip drivers and have all
> the logic we need to sort that out at runtime.
I don't dispute this, and maybe I'm just tired of seeing pointlessly
divergent HW being pushed around.
> My feeling is that the original approach taken in the early version
> of the patch set was actually better, given all the problems with
> integrating this nicely into the gic driver.
>
> Would you be happier with that? The downside of that would be
> that some driver bugs would get fixed in one driver but not the
> other one, which is why we normally try to avoid it. On the other
> hand, it means that the normal GIC driver does not get polluted
> with hacks that are only needed for the hip04 version and there
> is an obvious way to disable the driver at compile time when you
> build for other platforms.
Indeed. I think I'd be much happier with a completely separate driver.
There will even be some benefits to the hip04 driver, as it won't have
to deal with the non-DT stuff and the crazy gic_arch_extn.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2014-07-29 13:41 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 13:57 [PATCH v15 00/12] enable Hisilicon HiP04 Haojian Zhuang
2014-07-28 13:57 ` [PATCH v15 01/12] irq: gic: support hip04 gic Haojian Zhuang
2014-07-28 17:38 ` Marc Zyngier
2014-07-29 13:05 ` Arnd Bergmann
2014-07-29 13:19 ` Will Deacon
2014-07-29 13:41 ` Marc Zyngier [this message]
2014-07-28 13:57 ` [PATCH v15 02/12] ARM: mcpm: support 4 clusters Haojian Zhuang
2014-07-28 13:57 ` [PATCH v15 03/12] ARM: hisi: enable MCPM implementation Haojian Zhuang
2014-07-28 13:57 ` [PATCH v15 04/12] ARM: hisi: enable HiP04 Haojian Zhuang
2014-07-28 14:38 ` Arnd Bergmann
2014-07-28 13:57 ` [PATCH v15 05/12] document: dt: add the binding on HiP04 Haojian Zhuang
2014-07-28 14:41 ` Arnd Bergmann
2014-07-28 13:57 ` [PATCH v15 06/12] document: dt: add the binding on HiP04 clock Haojian Zhuang
2014-07-28 17:54 ` Mark Rutland
2014-07-29 2:25 ` Haojian Zhuang
2014-07-29 9:55 ` Arnd Bergmann
2014-07-29 10:40 ` Haojian Zhuang
2014-07-29 12:38 ` Mark Rutland
2014-07-28 13:57 ` [PATCH v15 07/12] ARM: dts: append hip04 dts Haojian Zhuang
2014-07-28 18:06 ` Mark Rutland
2014-07-29 2:44 ` Haojian Zhuang
2014-07-29 3:53 ` Olof Johansson
2014-07-29 4:00 ` Olof Johansson
2014-08-01 12:02 ` Haojian Zhuang
2014-07-29 10:58 ` Haojian Zhuang
2014-07-29 16:56 ` Olof Johansson
2014-07-29 11:12 ` Will Deacon
2014-07-29 11:32 ` Haojian Zhuang
2014-07-29 12:13 ` Will Deacon
2014-07-29 12:15 ` Haojian Zhuang
2014-07-29 12:22 ` Will Deacon
2014-07-29 12:32 ` Mark Rutland
2014-07-29 17:01 ` Olof Johansson
2014-07-29 17:33 ` Mark Rutland
2014-07-30 11:26 ` Leif Lindholm
2014-07-28 13:57 ` [PATCH v15 08/12] ARM: config: append lpae configuration Haojian Zhuang
2014-07-29 4:05 ` Olof Johansson
2014-07-29 10:43 ` Haojian Zhuang
2014-07-31 1:01 ` Olof Johansson
2014-07-31 2:24 ` Haojian Zhuang
2014-07-31 3:55 ` Olof Johansson
2014-07-31 5:30 ` Haojian Zhuang
2014-07-31 14:41 ` Arnd Bergmann
2014-08-01 12:16 ` Haojian Zhuang
2014-07-28 13:57 ` [PATCH v15 09/12] ARM: config: append hip04_defconfig Haojian Zhuang
2014-07-29 4:07 ` Olof Johansson
2014-07-28 13:57 ` [PATCH v15 10/12] ARM: hisi: enable erratum 798181 of A15 on HiP04 Haojian Zhuang
2014-07-29 4:08 ` Olof Johansson
2014-07-29 10:41 ` Haojian Zhuang
2014-07-28 13:57 ` [PATCH v15 11/12] virt: arm: support hip04 gic Haojian Zhuang
2014-07-28 18:00 ` Marc Zyngier
2014-07-29 2:31 ` Haojian Zhuang
2014-07-29 8:47 ` Marc Zyngier
2014-07-28 13:57 ` [PATCH v15 12/12] ARM: debug: add HiP04 debug uart Haojian Zhuang
2014-07-28 14:43 ` [PATCH v15 00/12] enable Hisilicon HiP04 Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D7A482.7050705@arm.com \
--to=marc.zyngier@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox