From: tomasz.figa@gmail•com (Tomasz Figa)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v5 05/10] ARM: dts: Move dp_hpd from exynos5250 into smdk5250 and snow
Date: Fri, 01 Aug 2014 22:57:06 +0200 [thread overview]
Message-ID: <53DBFF22.3010905@gmail.com> (raw)
In-Reply-To: <53DBFE8A.7020505@suse.de>
On 01.08.2014 22:54, Andreas F?rber wrote:
> Doug,
>
> Am 01.08.2014 22:33, schrieb Doug Anderson:
>> On Thu, Jul 31, 2014 at 9:54 PM, Andreas F?rber <afaerber@suse•de> wrote:
>>> Spring uses a different GPIO, so this is not a generic SoC piece.
>>>
>>> Suggested-by: Tomasz Figa <t.figa@samsung•com>
>>> Signed-off-by: Andreas F?rber <afaerber@suse•de>
>>> ---
>>> v5: New (Tomasz Figa)
>>> Frees dp_hpd for Spring.
>>>
>>> arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 7 -------
>>> arch/arm/boot/dts/exynos5250-smdk5250.dts | 9 +++++++++
>>> arch/arm/boot/dts/exynos5250-snow.dts | 7 +++++++
>>> 3 files changed, 16 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
>>> index 886cfca044ac..ed0e5230514b 100644
>>> --- a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
>>> +++ b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
>>> @@ -581,13 +581,6 @@
>>> samsung,pin-pud = <0>;
>>> samsung,pin-drv = <0>;
>>> };
>>> -
>>> - dp_hpd: dp_hpd {
>>> - samsung,pins = "gpx0-7";
>>> - samsung,pin-function = <3>;
>>> - samsung,pin-pud = <0>;
>>> - samsung,pin-drv = <0>;
>>> - };
>>> };
>>>
>>> pinctrl at 13400000 {
>>> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>>> index aaa055ac0fe3..5d30fe1dcda4 100644
>>> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>>> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>>> @@ -414,3 +414,12 @@
>>> };
>>> };
>>> };
>>> +
>>> +&pinctrl_0 {
>>> + dp_hpd: dp_hpd {
>>> + samsung,pins = "gpx0-7";
>>> + samsung,pin-function = <3>;
>>> + samsung,pin-pud = <0>;
>>> + samsung,pin-drv = <0>;
>>> + };
>>> +};
>>> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
>>> index c4b0c73c736d..a9a2f2743794 100644
>>> --- a/arch/arm/boot/dts/exynos5250-snow.dts
>>> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
>>> @@ -547,6 +547,13 @@
>>> };
>>>
>>> &pinctrl_0 {
>>> + dp_hpd: dp_hpd {
>>> + samsung,pins = "gpx0-7";
>>> + samsung,pin-function = <3>;
>>> + samsung,pin-pud = <0>;
>>> + samsung,pin-drv = <0>;
>>> + };
>>> +
>>
>> NAK. dp_hpd is a generic SoC piece. Pin function 0 and 1 are GPIOs.
>> Pin function 3 is special function. This pin _is_ the hot plug detect
>> pin for display port. When it's set as special function 3 it goes
>> straight into the hot plug logic of the display port controller.
>>
>> Spring may have had its reasons to detect hot plug events on a GPIO
>> instead of using this pin, but that doesn't make this pin any less the
>> "hot plug pin".
>
> Please advise how to handle it then: Should there be two different
> pinctrl entries (if so, how should it be named?),
IMHO this is the right way. Just name the GPIO variant dp_hpd_gpio.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-08-01 20:57 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 4:54 [PATCH v5 00/10] ARM: dts: exynos: Prepare Spring Andreas Färber
2014-08-01 4:54 ` [PATCH v5 01/10] ARM: dts: Fix MMC pinctrl for exynos5250-snow Andreas Färber
2014-08-01 16:26 ` Doug Anderson
2014-08-18 18:37 ` Kukjin Kim
2014-08-18 18:48 ` Tomasz Figa
2014-08-18 20:03 ` Kukjin Kim
2014-08-18 20:13 ` Andreas Färber
2014-08-01 4:54 ` [PATCH v5 02/10] ARM: dts: Fold exynos5250-cros-common into exynos5250-snow Andreas Färber
2014-08-01 16:45 ` Doug Anderson
2014-08-18 20:03 ` Kukjin Kim
2014-08-01 4:54 ` [PATCH v5 03/10] ARM: dts: Clean up exynos5250-snow Andreas Färber
2014-08-01 20:24 ` Doug Anderson
2014-08-01 20:44 ` Andreas Färber
2014-08-01 4:54 ` [PATCH v5 04/10] ARM: dts: Fill in bootargs for exynos5250-snow Andreas Färber
2014-08-01 20:28 ` Doug Anderson
2014-08-01 21:10 ` Andreas Färber
2014-08-02 5:01 ` Doug Anderson
2014-08-01 4:54 ` [PATCH v5 05/10] ARM: dts: Move dp_hpd from exynos5250 into smdk5250 and snow Andreas Färber
2014-08-01 20:33 ` Doug Anderson
2014-08-01 20:54 ` Andreas Färber
2014-08-01 20:57 ` Tomasz Figa [this message]
2014-08-05 12:16 ` Jingoo Han
2014-08-10 9:15 ` Andreas Färber
2014-08-11 10:24 ` Jingoo Han
2014-08-01 4:54 ` [PATCH v5 06/10] ARM: dts: Clean up exynos5250-smdk5250 Andreas Färber
2014-08-01 11:42 ` Andreas Färber
2014-08-01 20:37 ` Doug Anderson
2014-08-01 4:54 ` [PATCH v5 07/10] ARM: dts: Clean up exynos5250-arndale Andreas Färber
2014-08-01 21:03 ` Tomasz Figa
2014-08-01 4:54 ` [PATCH v5 08/10] ARM: dts: Fix apparent GPIO typo in exynos5250-arndale Andreas Färber
2014-08-01 4:54 ` [PATCH v5 09/10] ARM: dts: Simplify USB3503 on exynos5250-arndale Andreas Färber
2014-08-01 4:54 ` [PATCH v5 10/10] ARM: dts: Add exynos5250-spring device tree Andreas Färber
2014-08-01 5:16 ` [PATCH v5 00/10] ARM: dts: exynos: Prepare Spring Andreas Färber
2014-08-01 21:07 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DBFF22.3010905@gmail.com \
--to=tomasz.figa@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox