From: ttynkkynen@nvidia•com (Tuomas Tynkkynen)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/3] of: Add of_match_machine helper
Date: Fri, 8 Aug 2014 16:23:26 +0300 [thread overview]
Message-ID: <53E4CF4E.6010500@nvidia.com> (raw)
In-Reply-To: <20140808094123.GC5387@ulmo>
On 08/08/14 12:41, Thierry Reding wrote:
>
>> +const struct of_device_id *of_match_machine(const struct of_device_id *matches)
>> +{
>> + const struct of_device_id *match;
>> + struct device_node *root;
>> +
>> + root = of_find_node_by_path("/");
>> + if (!root)
>> + return NULL;
>> +
>> + match = of_match_node(matches, root);
>> + of_node_put(root);
>> + return match;
>> +}
>> +EXPORT_SYMBOL(of_match_machine);
>
> I wonder if of_find_node_by_path("/") is somewhat overkill here. Perhaps
> simply of_node_get(of_allnodes) would be more appropriate here since the
> function is implemented in the core?
of_machine_is_compatible() uses of_find_node_by_path("/") as well, of_allnodes
seems to be only used when during iterating. So I'd prefer to have them
consistent.
--
nvpublic
next prev parent reply other threads:[~2014-08-08 13:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 23:01 [PATCH 0/3] Introduce of_match_machine() helper Tuomas Tynkkynen
2014-08-07 23:01 ` [PATCH 1/3] of: Add of_match_machine helper Tuomas Tynkkynen
2014-08-08 9:41 ` Thierry Reding
2014-08-08 13:23 ` Tuomas Tynkkynen [this message]
2014-08-08 19:01 ` Rob Herring
2014-08-17 15:31 ` Grant Likely
2014-08-17 15:28 ` Grant Likely
2014-08-18 10:10 ` Tuomas Tynkkynen
2014-08-07 23:01 ` [PATCH 2/3] soc/tegra: Use of_match_machine in soc_is_tegra() Tuomas Tynkkynen
2014-08-07 23:28 ` Stephen Warren
2014-08-08 9:43 ` Thierry Reding
2014-08-07 23:01 ` [PATCH 3/3] cpuidle: big.LITTLE: Use of_match_machine Tuomas Tynkkynen
2014-08-08 9:45 ` Thierry Reding
2014-08-25 17:45 ` [PATCH 0/3] Introduce of_match_machine() helper Stephen Warren
2014-09-19 13:12 ` Peter De Schrijver
2014-09-24 7:44 ` Peter De Schrijver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E4CF4E.6010500@nvidia.com \
--to=ttynkkynen@nvidia$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox